8000 resolve #81 by kieranjmartin · Pull Request #91 · gowerc/diffdf · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

resolve #81 #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 3, 2024
Merged

resolve #81 #91

merged 4 commits into from
May 3, 2024

Conversation

kieranjmartin
Copy link
Collaborator
@kieranjmartin kieranjmartin commented Apr 5, 2024 •
edited by gowerc
Loading

Closes #81

int64 is not considered numeric annoyingly, so need to make a new method just for it!

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Apr 5, 2024 •
edited
Loading

badge

Code Coverage Summary

Filename                Stmts    Miss  Cover    Missing
--------------------  -------  ------  -------  --------------------------------
R/ascii_tables.R           85       6  92.94%   10, 129, 158, 162, 165, 168
R/cast_variables.R         49       0  100.00%
R/diffdf.R                127      22  82.68%   134, 197, 201, 205, 288-305, 332
R/generate_keyname.R        8       1  87.50%   17
R/identify.R              127       9  92.91%   33, 277-284
R/is_different.R           50       1  98.00%   17
R/issuerows.R              37       2  94.59%   35, 41
R/issues.R                 12       1  91.67%   45
R/misc_functions.R         14       2  85.71%   12, 16
R/print.R                  23       2  91.30%   47-48
TOTAL                     532      46  91.35%

Results for commit: 1694276

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Apr 5, 2024 •
edited
Loading

Unit Tests Summary

  1 files   10 suites   6s ⏱️
 39 tests  39 ✅ 0 💤 0 ❌
583 runs  583 ✅ 0 💤 0 ❌

Results for commit 1694276.

♻️ This comment has been updated with latest results.

@kieranjmartin kieranjmartin requested a review from gowerc April 9, 2024 15:33
@kieranjmartin
Copy link
Collaborator Author

@gowerc could you look at merging this?

@gowerc gowerc merged commit 1be0ef6 into master May 3, 2024
@gowerc gowerc deleted the 81_int64 branch May 3, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gowerc gowerc gowerc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with int64 columns tolerance is not taken into account
2 participants
@kieranjmartin @gowerc
0