8000 Add Row Limit to print method by kieranjmartin · Pull Request #93 · gowerc/diffdf · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add Row Limit to print method #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
May 3, 2024
Merged

Add Row Limit to print method #93

merged 10 commits into from
May 3, 2024

Conversation

kieranjmartin
Copy link
Collaborator

Replaces #83 ; fixes git conflict and makes some changes to functionality from the suggested PR. Specifically, now NULL will trigger all rows being shown, which I think is more consistent.

Brian Repko and others added 4 commits July 28, 2023 08:21
add row_limit with ability to print all
708fee4
add test for row_limit functionality
837076c
@kieranjmartin
resolve merge conflicts
bc6bf00 
Merge branch 'master' of github.com:brianrepko/diffdf into brianrepko-master

# Conflicts:
#	R/ascii_tables.R
#	R/issues.R
#	R/print.R
@kieranjmartin
switch to null, and add tests for inputs
ccfe5be
@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Apr 9, 2024 •
edited
Loading

badge

Code Coverage Summary

Filename                Stmts    Miss  Cover    Missing
--------------------  -------  ------  -------  --------------------------------
R/ascii_tables.R           85       6  92.94%   10, 129, 158, 162, 165, 168
R/cast_variables.R         49       0  100.00%
R/diffdf.R                127      22  82.68%   134, 197, 201, 205, 288-305, 332
R/generate_keyname.R        8       1  87.50%   17
R/identify.R              127       9  92.91%   33, 277-284
R/is_different.R           49       1  97.96%   17
R/issuerows.R              37       2  94.59%   35, 41
R/issues.R                 12       1  91.67%   45
R/misc_functions.R         14       2  85.71%   12, 16
R/print.R                  23       2  91.30%   47-48
TOTAL                     531      46  91.34%

Results for commit: be46928

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Apr 9, 2024 •
edited
Loading

Unit Tests Summary

  1 files   10 suites   5s ⏱️
 38 tests  38 ✅ 0 💤 0 ❌
579 runs  579 ✅ 0 💤 0 ❌

Results for commit be46928.

♻️ This comment has been updated with latest results.

@kieranjmartin kieranjmartin requested a review from gowerc April 9, 2024 16:03
gowerc
gowerc reviewed Apr 9, 2024
View reviewed changes
gowerc
gowerc reviewed Apr 9, 2024
View reviewed changes
gowerc
gowerc reviewed Apr 9, 2024
View reviewed changes
gowerc
gowerc reviewed Apr 9, 2024
View reviewed changes
@gowerc
Copy link
Owner
gowerc commented Apr 9, 2024

@kieranjmartin please correct me if I have any of the following wrong:

@brianrepko - So a few weeks ago we updated the repo to use GitHub actions which required a ton of white space edits to appease the lintr. As a result your PR was conflicting with master, additionally I think @kieranjmartin wanted to make a few small edits so this PR here is a modified version of your PR. We've accredited you in the NEWS.md and I believe Kieran forked from your original PR so your commit attribution is still recorded as well.

Thank you for your contributions !

This was referenced Apr 9, 2024
Closed
Closed
@brianrepko
Copy link

@kieranjmartin please correct me if I have any of the following wrong:

@brianrepko - So a few weeks ago we updated the repo to use GitHub actions which required a ton of white space edits to appease the lintr. As a result your PR was conflicting with master, additionally I think @kieranjmartin wanted to make a few small edits so this PR here is a modified version of your PR. We've accredited you in the NEWS.md and I believe Kieran forked from your original PR so your commit attribution is still recorded as well.

Thank you for your contributions !

sounds good to me

gowerc
gowerc reviewed Apr 10, 2024
View reviewed changes
@kieranjmartin
Copy link
Collaborator Author

@gowerc all comments resolved, please merge if happy (assuming this pipeline works...)

@gowerc gowerc self-requested a review May 3, 2024 13:37
@gowerc gowerc merged commit 6707cb7 into master May 3, 2024
@gowerc gowerc deleted the brianrepko-master branch May 3, 2024 13:37
@gowerc gowerc changed the title Brianrepko master Add Row Limit to print method Jun 5, 2024
@gowerc gowerc mentioned this pull request Jun 5, 2024
Closed
@gowerc gowerc mentioned this pull request Jul 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianrepko brianrepko brianrepko left review comments

@gowerc gowerc gowerc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kieranjmartin @gowerc @brianrepko
0