8000 Hotfix rng by gowerc · Pull Request #23 · gowerc/diffdf · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Hotfix rng #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 12, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Package: diffdf
Type: Package
Title: Dataframe Difference Tool
Version: 1.0.2
Version: 1.0.3
Authors@R: c(
person("Craig" ,"Gower" , email = "craig.gower@roche.com" , role = c("cre","aut")),
person("Kieran", "Martin" , email = "kieran.martin@roche.com" , role = "aut")
Expand Down
6 changes: 5 additions & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
# diffdf 1.0.3

- No new functionality
- Update to make package compatible with the changes made to sampling within core R

# diffdf 1.0.2

- No new functionality
Expand All @@ -10,7 +15,6 @@
- Added Travis
- Added CodeCov


# diffdf 1.0.0

- Initial Release !!
7 changes: 3 additions & 4 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
## Release summary
In this version I have:
- Updated the package to be compatible with tibble 2.0.0 to fix the related automated test errors
- Updated the package to use suppressWarnings(RNGversion("3.5.0")) wherever set.seed() has been used to make sure test results and vignette results are consistent after the planned changes to the random number generator

## Test environments
- local Windows 10 R 3.5.1
- local Ubuntu 18.04.1 LTS R 3.5.2
- Win-Builder R-devel
- local Mac OS Mojave R 3.5.2
- Win-Builder R-release
- Debian Linux R-release (via rhub)

## R CMD check results
Expand Down
4 changes: 2 additions & 2 deletions man/cast_variables.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions tests/testthat/helper-create_test_data.R
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ library(diffdf)
library(purrr)
library(tibble)

suppressWarnings(RNGversion("3.5.0"))
set.seed(20202)

LENGTH <- 20
Expand Down
2 changes: 1 addition & 1 deletion tests/testthat/test-core.R
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ context("Testing entire function")
#
# Set up testing datasets
#

suppressWarnings(RNGversion("3.5.0"))
set.seed(101010223)


Expand Down
2 changes: 2 additions & 0 deletions utils/benchmarks/benchmark.R
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
library(dplyr)
library(diffdf)

suppressWarnings(RNGversion("3.5.0"))

benchmark <- function(nrow, ncol, seedin, same = T){
set.seed(seedin)
data1 <- rnorm(nrow*ncol)
Expand Down
3 changes: 3 additions & 0 deletions vignettes/diffdf-basic.Rmd
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,10 @@ Here we show the basic functionality of `diffdf` using a dummy data set.
library(diffdf)

LENGTH = 30

suppressWarnings(RNGversion("3.5.0"))
set.seed(12334)

test_data <- tibble::tibble(
ID = 1:LENGTH,
GROUP1 = rep( c(1,2) , each = LENGTH/2),
Expand Down
0