pyproject.toml: explicitly set build-backend #424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, pyproject.toml would not set an build-backend, while the project also has no setup.py. According to some experts from Gentoo's Python project, this is a violation of PEP 517, which states """ If the pyproject.toml file is absent, or the build-backend key is missing, the source tree is not using this specification, and tools should revert to the legacy behaviour of running setup.py (either directly, or by implicitly invoking the setuptools.build_meta:__legacy__ backend). """ However, the project has no setup.py to invoke, hence Gentoo's infrastructor for building Python packages fails without the build-backend key being set.
d12b20f to
45ccea4
Compare
|
Thanks! I've merged all 3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am currently in the progress of bumping Tex Live in Gentoo and this change is required for the bump.
Prior to this change, pyproject.toml would not set an build-backend, while the project also has no setup.py.
According to some experts from Gentoo's Python project, this is a violation of PEP 517, which states
However, the project has no setup.py to invoke, hence Gentoo's infrastructor for building Python packages fails without the build-backend key being set.