Refactor that not all storage texture support read-only #4411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code assumed all textures marked as 'storage: true' could both do `read-only` and `write-only` but `bgra8norm` can never do `read-only`. Refactor be able to separately check for read-only and write-only usage. gpuweb/gpuweb#5232
8fdb049 to
489bf70
Compare
shrekshao
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Alread
5DA9
y have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code assumed all textures marked as 'storage: true' could both do
read-onlyandwrite-onlybutbgra8normcan never doread-only.Refactor be able to separately check for read-only and write-only usage.
Issue: