Ensure tags are not duplicates during bookmark load #1166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it ok to add such refactors, or should I create separate MR? (I would do it for bigger ones for sure). |
|
I think, it is better to switch to using shared pointers instead of raw pointers for taginfo. It solves tag corruption when Gqrx is built with Qt6. Take a look at this PR #1145 |
|
Could you open an issue and provide exact steps to reproduce tag duplication bug? |
|
Sure #1145 can be solved first, I does not mind to rebase. |
Duplicates can be introduced in several ways. User can add duplicate tag now, but it seems tath past and current GQRX contains some bugs related to bookmarks/tags and the saved content is sometimes crappy.
afcb3fd to
70c38d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicates can be introduced in several ways. User can add duplicate
tag now, but it seems tath past and current GQRX contains some bugs
related to bookmarks/tags and the saved content is sometimes crappy.