Fix macOS Intel architecture detection #356
Conversation
There was a problem hiding this comment.
Thank you for your contribution!
The DCO check is failing, please look into that as we can't accept the PR otherwise.
Can you provide more details about why you should change startsWith to contains for Apple? Example strings can help. Covering some sample strings with unit tests would work too.
Can you also provide the string with CPU name from the output for sysctl machdep for the hardware in question?
Signed-off-by: MSDarwish2000 <msdarwish@mayakapps.com>
I have fixed it. Thank you for the clarification.
It was more of futureproofing if Apple decided to change it similar to Intel. On the latest commit, I reverted it.
I have written a unit test for this. Most values are retrieved by searching online on CPU databases. My output is: |
Newer Intel CPUs Display Name doesn't start with "Intel". For example, it can look like "13th Gen Intel(R) Core(TM) i5-13600K". While newer Intel processors are not officially supported by macOS, those can be present in experimental setups.
A better approach would be finding a different way than depending on display name as even Apple may change their mind about how to structure it.