8000 Fix concurrent access crash in PIDsFilter by mariomac · Pull Request #479 · grafana/beyla · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix concurrent access crash in PIDsFilter #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 30, 2023
Merged

Fix concurrent access crash in PIDsFilter #479

merged 2 commits into from
Nov 30, 2023

Conversation

mariomac
Copy link
Contributor

Fixes an improbable but possible crash in Beyla:

crash.txt

@mariomac mariomac requested a review from grcevski as a code owner November 30, 2023 13:41
@codecov-commenter
Copy link
codecov-commenter commented Nov 30, 2023 •
edited
Loading

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (be81a91) 76.98% compared to head (87c8334) 41.75%.

Files Patch % Lines
pkg/internal/ebpf/common/pids.go 41.37% 17 Missing ⚠️
pkg/internal/ebpf/httpfltr/httpfltr.go 0.00% 5 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##             main     #479       +/-   ##
===========================================
- Coverage   76.98%   41.75%   -35.24%     
===========================================
  Files          65       63        -2     
  Lines        5162     5051      -111     
===========================================
- Hits         3974     2109     -1865     
- Misses        961     2806     +1845     
+ Partials      227      136       -91
Flag Coverage Δ
integration-test ?
unittests 41.75% <35.29%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

grcevski
grcevski approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor
@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing it!

@mariomac mariomac merged commit 26e3210 into grafana:main Nov 30, 2023
@mariomac mariomac deleted the fix-pids-crash branch November 30, 2023 15:29
mattdurham pushed a commit to mattdurham/beyla that referenced this pull request Jan 22, 2025
@mariomac
Fix concurrent access crash in PIDsFilter (grafana#479)
9b8ac6a 
* Fix concurrent access crash in PIDsFilter

* Fix currentPID usage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grcevski grcevski grcevski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mariomac @codecov-commenter @grcevski
0