Fix host parsing bug #486
Merged
Fix host parsing bug #486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grcevski
commented
Dec 5, 2023
| @@ -435,7 +435,7 @@ func (event *BPFHTTPInfo) method() string { | |||
| } | |||
|
|
|||
| func (event *BPFHTTPInfo) hostFromBuf() (string, int) { | |||
| buf := string(event.Buf[:]) | |||
| buf := cstr(event.Buf[:]) | |||
There was a problem hiding this comment.
Use cstr here to remove any trailing null characters.
grcevski
commented
Dec 5, 2023
| @@ -446,6 +446,10 @@ func (event *BPFHTTPInfo) hostFromBuf() (string, int) { | |||
|
|
|||
| rIdx := strings.Index(buf, "\r") | |||
|
|
|||
| if rIdx < 0 { | |||
There was a problem hiding this comment.
This is the actual bug fix.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.0 #486 +/- ##
===============================================
+ Coverage 78.21% 78.47% +0.25%
===============================================
Files 61 61
Lines 5032 5035 +3
===============================================
+ Hits 3936 3951 +15
+ Misses 883 875 -8
+ Partials 213 209 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Amazing! We can cut a 1.0.2 release after merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the host parsing fallback path for the HTTP request parser. In SSL mode we sometimes can't find the connection information, because of internal process threading models, so we have a fallback path to look for "Host: " in the headers. However, the code didn't anticipate our limited buffer size of 160 characters, so the '\r' may not be in the string.