8000 Fix Prometheus connection issue in one K8s integration test by mariomac · Pull Request #1617 · grafana/beyla · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix Prometheus connection issue in one K8s integration test #1617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 6, 2025
Merged

Fix Prometheus connection issue in one K8s integration test #1617

merged 5 commits into from
Feb 6, 2025

Conversation

mariomac
Copy link
Contributor
@mariomac mariomac commented Feb 6, 2025 •
edited
Loading

The cause was that we forgot to set proper nodeAffinity constraints to the Prometheus Pod, so it was often allocated in the node that doesn't expose the 9090 port.

However I took the occasion to update the prometheus image to something a bit newer.

@mariomac mariomac requested a review from a team as a code owner February 6, 2025 13:27
@codecov Codecov
Copy link
codecov bot commented Feb 6, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.04%. Comparing base (53ed88f) to head (f8fcebc).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1617      +/-   ##
==========================================
+ Coverage   63.86%   71.04%   +7.18%     
==========================================
  Files         196      197       +1     
  Lines       19862    19871       +9     
==========================================
+ Hits        12684    14118    +1434     
+ Misses       6381     5069    -1312     
+ Partials      797      684     -113
Flag Coverage Δ
integration-test 52.75% <ø> (+0.03%) ⬆️
k8s-integration-test 53.80% <ø> (+0.01%) ⬆️
oats-test 34.55% <ø> (-0.11%) ⬇️
unittests 47.06% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

grcevski
grcevski approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor
@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing this.

@grcevski grcevski merged commit 80f93fe into grafana:main Feb 6, 2025
13 checks passed
@grcevski grcevski mentioned this pull request Feb 6, 2025
Merged
@mariomac mariomac deleted the fix-prom-test branch February 6, 2025 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grcevski grcevski grcevski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mariomac @grcevski
0