8000 Remove codecov from VM tests by rafaelroquetto · Pull Request #1647 · grafana/beyla · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove codecov from VM tests #1647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 12, 2025
Merged

Remove codecov from VM tests #1647

merged 1 commit into from
Feb 12, 2025

Conversation

rafaelroquetto
Copy link
Contributor

The VM tests never generate any codecov data, so trying to upload it generates a warning. Generating coverage data for these tests is redundant since they are just a subset of the integration tests.

@rafaelroquetto rafaelroquetto requested a review from a team as a code owner February 12, 2025 19:45
grcevski
grcevski reviewed Feb 12, 2025
View reviewed changes
Copy link
Contributor
@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe Mario at some point added the coverage for integration tests, since they exercise parts of the codebase the regular tests don't. I think we make cov data when I run the integration tests locally.

grcevski
grcevski approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor
@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Sorry, I misunderstood, this removes only the VM tests coverage.

@rafaelroquetto rafaelroquetto merged commit fd2b06e into main Feb 12, 2025
14 checks passed
@rafaelroquetto rafaelroquetto deleted the vm_workflow_fix branch February 12, 2025 21:12
rafaelroquetto added a commit that referenced this pull request Feb 13, 2025
@rafaelroquetto
Revert "Remove codecov from VM tests (#1647)"
ad3f87e 
This reverts commit fd2b06e.
rafaelroquetto added a commit that referenced this pull request Feb 13, 2025
@rafaelroquetto
Revert building binaries on CI (#1654)
6d92f1a 
* Revert "Remove codecov from VM tests (#1647)"

This reverts commit fd2b06e.

* Revert "Remove stray debug message (#1648)"

This reverts commit 41f2551.

* Revert "Build ebpf objects on CI (#1639)"

This reverts commit 4639d0e.

* Update eBPF files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grcevski grcevski grcevski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rafaelroquetto @grcevski
0