8000 More logs for process discovery by mariomac · Pull Request #1658 · grafana/beyla · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

More logs for process discovery #1658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 14, 2025
Merged

More logs for process discovery #1658

merged 2 commits into from
Feb 14, 2025

Conversation

mariomac
Copy link
Contributor

Tries to provide more insights in the flaky K8s test.

The httpinger process is discovered by the process watcher, decorated by the kube watcher enricher, and then passed to the criteria matcher:

2025-02-13T01:10:08.275122516Z stdout F time=2025-02-13T01:10:08.274Z level=DEBUG msg="Executable ready" component=discover.ProcessWatcher path=/httppinger pid=2586
2025-02-13T01:10:08.275142573Z stdout F time=2025-02-13T01:10:08.275Z level=DEBUG msg="new process watching events" component=discover.ProcessWatcher interval=500ms events="[{Type:0 Obj:{pid:2586 openPorts:[] metadata:map[] podLabels:map[]}} {Type:1 Obj:{pid:2576 openPorts:[] metadata:map[] podLabels:map[]}} {Type:1 Obj:{pid:2592 openPorts:[] metadata:map[] podLabels:map[]}} {Type:1 Obj:{pid:2593 openPorts:[] metadata:map[] podLabels:map[]}}]"
2025-02-13T01:10:08.275150308Z stdout F time=2025-02-13T01:10:08.275Z level=DEBUG msg="new process" component=discover.watcherKubeEnricher pid=2586

The criteria matcher receives it, it theoretically has all the K8s metadata of the pod (seen in other logs), but the criteria don't match:

2025-02-13T01:10:08.275292092Z stdout F time=2025-02-13T01:10:08.275Z level=DEBUG msg="filtering processes" component=discover.CriteriaMatcher len=4
2025-02-13T01:10:08.275542091Z stdout F time=2025-02-13T01:10:08.275Z level=DEBUG msg="deleted untracked process. Ignoring" component=discover.CriteriaMatcher pid=2576
2025-02-13T01:10:08.275547481Z stdout F time=2025-02-13T01:10:08.275Z level=DEBUG msg="deleted untracked process. Ignoring" component=discover.CriteriaMatcher pid=2592
2025-02-13T01:10:08.275549795Z stdout F time=2025-02-13T01:10:08.275Z level=DEBUG msg="deleted untracked process. Ignoring" component=discover.CriteriaMatcher pid=2593
2025-02-13T01:10:08.275551719Z stdout F time=2025-02-13T01:10:08.275Z level=DEBUG msg="processes matching selection criteria" component=discover.CriteriaMatcher len=0

Adding more logs to see why.

@mariomac mariomac requested a review from a team as a code owner February 13, 2025 11:50
@codecov Codecov
Copy link
codecov bot commented Feb 13, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 71.20%. Comparing base (6d92f1a) to head (1ccc625).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
pkg/internal/discover/matcher.go 77.77% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1658      +/-   ##
==========================================
+ Coverage   71.13%   71.20%   +0.06%     
==========================================
  Files         197      197              
  Lines       19926    19936      +10     
==========================================
+ Hits        14174    14195      +21     
+ Misses       5068     5059       -9     
+ Partials      684      682       -2
Flag Coverage Δ
integration-test 52.91% <50.00%> (+0.30%) ⬆️
k8s-integration-test 54.32% <70.00%> (+0.44%) ⬆️
oats-test 34.57% <50.00%> (-0.09%) ⬇️
unittests 47.17% <80.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

grcevski
grcevski approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor
@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mariomac mariomac merged commit 3d18075 into grafana:main Feb 14, 2025
13 checks passed
@mariomac mariomac deleted the fix-client-discovery branch February 14, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grcevski grcevski grcevski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mariomac @grcevski
0