8000 Remove mariomac/pipes library from Network metrics pipeline by mariomac · Pull Request #1827 · grafana/beyla · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove mariomac/pipes library from Network metrics pipeline #1827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 15, 2025
Merged

Remove mariomac/pipes library from Network metrics pipeline #1827

merged 5 commits into from
Apr 15, 2025

Conversation

mariomac
Copy link
Contributor

This PR completes the removal of mariomac/pipes from the whole Beyla code base.

@mariomac mariomac requested a review from a team as a code owner April 14, 2025 13:42
marctc
marctc approved these changes Apr 14, 2025
View reviewed changes
Copy link
Contributor
@marctc marctc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔪

@codecov Codecov
Copy link
codecov bot commented Apr 14, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 92.03187% with 20 lines in your changes missing coverage. Please review.

Project coverage is 67.85%. Comparing base (8c40607) to head (95be1ff).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
pkg/export/prom/prom_net.go 70.00% 4 Missing and 2 partials ⚠️
pkg/export/otel/metrics_net.go 82.35% 2 Missing and 1 partial ⚠️
pkg/internal/netolly/flow/reverse_dns.go 86.95% 2 Missing and 1 partial ⚠️
pkg/internal/netolly/transform/cidr/cidr.go 83.33% 2 Missing and 1 partial ⚠️
pkg/internal/netolly/transform/k8s/kubernetes.go 86.95% 2 Missing and 1 partial ⚠️
pkg/internal/netolly/flow/tracer_ringbuf.go 66.66% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1827      +/-   ##
==========================================
+ Coverage   67.84%   67.85%   +0.01%     
==========================================
  Files         224      225       +1     
  Lines       22930    22962      +32     
==========================================
+ Hits        15556    15581      +25     
- Misses       6594     6598       +4     
- Partials      780      783       +3
Flag Coverage Δ
integration-test 55.14% <68.92%> (-0.07%) ⬇️
k8s-integration-test 53.47% <77.68%> (-0.13%) ⬇️
oats-test 35.04% <6.37%> (+0.14%) ⬆️
unittests 43.75% <75.29%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

grcevski
grcevski approved these changes Apr 14, 2025
View reviewed changes
Copy link
Contributor
@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mariomac mariomac merged commit ff386fe into grafana:main Apr 15, 2025
13 checks passed
@mariomac mariomac deleted the rm-pipes branch April 15, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marctc marctc marctc approved these changes

@grcevski grcevski grcevski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mariomac @marctc @grcevski
0