8000 Revert "Print printable characters in cfg.ProtocolDebug (#1738)" by marctc · Pull Request #1841 · grafana/beyla · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Revert "Print printable characters in cfg.ProtocolDebug (#1738)" #1841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2025
Merged

Revert "Print printable characters in cfg.ProtocolDebug (#1738)" #1841

merged 1 commit into from
Apr 17, 2025

Conversation

marctc
Copy link
Contributor
@marctc marctc commented Apr 16, 2025

This reverts commit 6e7397a.

@marctc marctc requested a review from a team as a code owner April 16, 2025 15:23
grcevski
grcevski approved these changes Apr 16, 2025
View reviewed changes
Copy link
Contributor
@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov Codecov
Copy link
codecov bot commented Apr 16, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 74.33%. Comparing base (9a58323) to head (6aa3b3d).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
pkg/internal/ebpf/common/tcp_detect_transform.go 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1841      +/-   ##
==========================================
+ Coverage   70.23%   74.33%   +4.09%     
==========================================
  Files         173      177       +4     
  Lines       18435    19194     +759     
==========================================
+ Hits        12948    14267    +1319     
+ Misses       4646     4201     -445     
+ Partials      841      726     -115
Flag Coverage Δ
integration-test 57.63% <0.00%> (+0.02%) ⬆️
k8s-integration-test 55.66% <0.00%> (ø)
oats-test 35.70% <0.00%> (ø)
unittests 46.14% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@marctc marctc merged commit ba1e002 into main Apr 17, 2025
13 checks passed
@marctc marctc deleted the revert_string_debug branch April 17, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grcevski grcevski grcevski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marctc @grcevski
0