8000 Avoid duplication/triplication/n-plication of traces for the same process by mariomac · Pull Request #371 · grafana/beyla · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Avoid duplication/triplication/n-plication of traces for the same process #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 24, 2023
Merged

Avoid duplication/triplication/n-plication of traces for the same process #371

merged 2 commits into from
Oct 24, 2023

Conversation

mariomac
Copy link
Contributor
@mariomac mariomac commented Oct 23, 2023 •
edited
Loading

Partially fixes bug #370 , by avoiding that the same executable is instrumented multiple times. Now metrics for the same process are not duplicated anymore.

This PR does not fix (will do in another PR):

  • Avoid reporting traces from processes that do not match the discovery selection criteria, but their executable has been already instrumented by another process so Beyla keeps reporting information.

@mariomac mariomac requested a review from grcevski as a code owner October 23, 2023 13:58
@mariomac mariomac added the bug label Oct 23, 2023
@codecov-commenter
Copy link
codecov-commenter commented Oct 23, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (80b463a) 81.09% compared to head (6ff0228) 80.52%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #371      +/-   ##
==========================================
- Coverage   81.09%   80.52%   -0.58%     
==========================================
  Files          51       51              
  Lines        3978     3999      +21     
==========================================
- Hits         3226     3220       -6     
- Misses        577      601      +24     
- Partials      175      178       +3
Flag Coverage Δ
integration-test 69.87% <100.00%> (-2.59%) ⬇️
unittests 42.19% <0.00%> (-0.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/internal/discover/attacher.go 85.52% <100.00%> (+4.49%) ⬆️
pkg/internal/discover/typer.go 87.82% <100.00%> (+5.68%) ⬆️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

grcevski
grcevski 8000 approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor
@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mariomac mariomac merged commit 4b7d6c8 into grafana:main Oct 24, 2023
@mariomac mariomac deleted the fix-370 branch October 24, 2023 07:29
@jdbaldry jdbaldry mentioned this pull request Nov 6, 2023
Merged
mattdurham pushed a commit to mattdurham/beyla that referenced this pull request Jan 22, 2025
@mariomac
Avoid duplication/triplication/n-plication of traces for the same pro…
df69248 
…cess (grafana#371)

* Failint tests for multi-process

* Avoid multi-instrumentation of the same process
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grcevski grcevski grcevski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mariomac @codecov-commenter @grcevski
0