8000 Integrate binary provisioning into k6 root command by pablochacin · Pull Request #4801 · grafana/k6 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Integrate binary provisioning into k6 root command #4801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Integrate binary provisioning into k6 root command #4801

wants to merge 2 commits into from
+180 −323

Conversation

pablochacin
Copy link
Contributor
@pablochacin pablochacin commented May 20, 2025 •
edited
Loading

What?

integrates the logic of binary provisioning into the k6 root command.

Why?

Presently, the logic of binary provisioning happens before the k6 root command is executed. This brings some additional complexity and some problems because the arguments passed to k6 have not yet been parsed .

Checklist

  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests for my changes.
  • I have run linter and tests locally (make check) and all pass.

Checklist: Documentation (only for k6 maintainers and if relevant)

Please do not merge this PR until the following items are filled out.

  • I have added the correct milestone and labels to the PR.
  • I have updated the release notes: link
  • I have updated or added an issue to the k6-documentation: grafana/k6-docs#NUMBER if applicable
  • I have updated or added an issue to the TypeScript definitions: grafana/k6-DefinitelyTyped#NUMBER if applicable

Related PR(s)/Issue(s)

Closes #4737
Closes #4758

@pablochacin pablochacin mentioned this pull request May 20, 2025
Closed
8 tasks
@pablochacin pablochacin force-pushed the binary-provisioning/integrate-root-cmd branch 2 times, most recently from 0e9b32c to 69c540b Compare May 20, 2025 15:59
@pablochacin pablochacin changed the title initial integration Integrate binary provisioning into k6 root command May 20, 2025
@pablochacin pablochacin force-pushed the binary-provisioning/integrate-root-cmd branch 2 times, most recently from fd5f482 to cd6b16a Compare May 22, 2025 15:42
@pablochacin
initial integration
e6564f6 
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
@pablochacin
refactor provisioning into an interface
b1ba5b7 
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
@pablochacin pablochacin force-pushed the binary-provisioning/integrate-root-cmd branch 2 times, most recently from e6edf2e to b1ba5b7 Compare May 23, 2025 07:44
@pablochacin pablochacin marked this pull request as ready for review May 23, 2025 11:00
@pablochacin pablochacin requested a review from a team as a code owner May 23, 2025 11:00
@pablochacin pablochacin requested review from mstoykov and codebien and removed request for a team May 23, 2025 11:00
This was referenced May 23, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstoykov mstoykov Awaiting requested review from mstoykov mstoykov is a code owner automatically assigned from grafana/k6-core

@codebien codebien Awaiting requested review from codebien codebien is a code owner automatically assigned from grafana/k6-core

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor provision callback into an interface Research alternatives for integrating binary provisioning logic into k6
1 participant
@pablochacin
0