8000 Feature/remove event listener by ekgns33 · Pull Request #4844 · grafana/k6 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Feature/remove event listener #4844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Feature/remove event listener #4844

wants to merge 3 commits into from

Conversation

ekgns33
Copy link
@ekgns33 ekgns33 commented Jun 11, 2025

What?

This PR adds Off function which remove registered event-listener function mapped to user specified event.

Why?

As Issue #4823 describes, k6 doesn't have interface for removing event-listener of websocket.

Checklist

  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests for my changes.
  • I have run linter and tests locally (make check) and all pass.

Checklist: Documentation (only for k6 maintainers and if relevant)

Please do not merge this PR until the following items are filled out.

  • I have added the correct milestone and labels to the PR.
  • I have updated the release notes: link
  • I have updated or added an issue to the k6-documentation: grafana/k6-docs#NUMBER if applicable
  • I have updated or added an issue to the TypeScript definitions: grafana/k6-DefinitelyTyped#NUMBER if applicable

Related PR(s)/Issue(s)

#4823< 8000 /p>

@ekgns33 ekgns33 requested a review from a team as a code owner June 11, 2025 04:16
@ekgns33 ekgns33 requested review from inancgumus and ankur22 and removed request for a team June 11, 2025 04:16
@CLAassistant
Copy link
CLAassistant commented Jun 11, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inancgumus inancgumus Awaiting requested review from inancgumus inancgumus is a code owner automatically assigned from grafana/k6-core

@ankur22 ankur22 Awaiting requested review from ankur22 ankur22 is a code owner automatically assigned from grafana/k6-core

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ekgns33 @CLAassistant
0