8000 Retire experimental/webcrypto by codebien · Pull Request #4851 · grafana/k6 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Retire experimental/webcrypto #4851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 16, 2025
Merged

Retire experimental/webcrypto #4851

merged 7 commits into from
Jun 16, 2025

Conversation

codebien
Copy link
Contributor
@codebien codebien commented Jun 13, 2025

What?

Closes #4852

Why?

As part of the steps to graduate an experimental module.

Checklist

  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests for my changes. I've tested it manually, as we don't add unit test for removed code).
  • I have run linter and tests locally (make check) and all pass.

Checklist: Documentation (only for k6 maintainers and if relevant)

Please do not merge this PR until the following items are filled out.

  • I have added the correct milestone and labels to the PR.
  • I have updated the release notes: link
  • I have updated or added an issue to the k6-documentation: grafana/k6-docs#NUMBER if applicable
  • I have updated or added an issue to the TypeScript definitions: grafana/k6-DefinitelyTyped#NUMBER if applicable

Related PR(s)/Issue(s)

@codebien codebien self-assigned this Jun 13, 2025
@codebien codebien force-pushed the graduate-webcrypto branch from 0b4d239 to ea31014 Compare June 13, 2025 13:50
@codebien codebien marked this pull request as ready for review June 13, 2025 16:32
@codebien codebien requested a review from a team as a code owner June 13, 2025 16:32
@codebien codebien requested review from ankur22 and joanlopez and removed request for a team June 13, 2025 16:32
joanlopez
joanlopez previously approved these changes Jun 16, 2025
@joanlopez joanlopez added this to the v1.1.0 milestone Jun 16, 2025
Copy link
Contributor
@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@codebien codebien merged commit 5d4cce5 into master Jun 16, 2025
53 of 56 checks passed
@codebien codebien deleted the graduate-webcrypto branch June 16, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove experimental module export
3 participants
0