8000 Parquet: Initialize parquet converter module by jesusvazquez · Pull Request #11226 · grafana/mimir · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Parquet: Initialize parquet converter module #11226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 16, 2025

Conversation

jesusvazquez
Copy link
Contributor
@jesusvazquez jesusvazquez commented Apr 15, 2025

Follow PR to the existing work in the branch that aims to register and initialize the new component.

Also renames parquet compactor into parquet converter

Also implements a quick allowlist method to make sure it only runs on a specific list of users

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@jesusvazquez jesusvazquez force-pushed the jvp/init-parquet-compactor-module branch from 6506fbc to 33acc93 Compare April 15, 2025 10:48
@jesusvazquez jesusvazquez changed the title Initialize parquet compactor module Parquet: Initialize parquet compactor module Apr 15, 2025
@jesusvazquez jesusvazquez force-pushed the jvp/init-parquet-compactor-module branch from edcb00d to 8591610 Compare April 15, 2025 13:37
@jesusvazquez jesusvazquez changed the title Parquet: Initialize parquet compactor module Parquet: Initialize parquet converter module Apr 15, 2025
Copy link
Contributor
github-actions bot commented Apr 15, 2025

💻 Deploy preview deleted.

@francoposa francoposa force-pushed the jvp/parquet-compactor branch from 3dea98e to d2c8220 Compare April 15, 2025 20:48
@jesusvazquez jesusvazquez force-pushed the jvp/init-parquet-compactor-module branch from 158c04b to d9d20e0 Compare April 16, 2025 14:30
@jesusvazquez jesusvazquez marked this pull request as ready for review April 16, 2025 14:32
@jesusvazquez jesusvazquez requested review from tacole02 and a team as code owners April 16, 2025 14:32
@jesusvazquez jesusvazquez merged commit 545923b into jvp/parquet-compactor Apr 16, 2025
20 of 28 checks passed
@jesusvazquez jesusvazquez deleted the jvp/init-parquet-compactor-module branch April 16, 2025 15:22
jesusvazquez added a commit that referenced this pull request Apr 16, 2025
* Initialize parquet compactor module

Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com>

* Rename to parquet converter

Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com>

* Implement allowlist

* fix reader tests

* Update docs

* also skip disallowed tenants when converting blocks

* fix initialization of allowedTenants

* various name changes

---------

Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com>
Co-authored-by: Nicolás Pazos <npazosmendez@gmail.com>
jesusvazquez added a commit that referenced this pull request Apr 16, 2025
* Initialize parquet compactor module

Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com>

* Rename to parquet converter

Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com>

* Implement allowlist

* fix reader tests

* Update docs

* also skip disallowed tenants when converting blocks

* fix initialization of allowedTenants

* various name changes

---------

Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com>
Co-authored-by: Nicolás Pazos <npazosmendez@gmail.com>
jesusvazquez added a commit that referenced this pull request Apr 16, 2025
* Initialize parquet compactor module

Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com>

* Rename to parquet converter

Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com>

* Implement allowlist

* fix reader tests

* Update docs

* also skip disallowed tenants when converting blocks

* fix initialization of allowedTenants

* various name changes

---------

Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com>
Co-authored-by: Nicolás Pazos <npazosmendez@gmail.com>
jesusvazquez added a commit that referenced this pull request Apr 16, 2025
* Parquet converter

Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com>
Co-authored-by: Nico Pazos <nicolas.pazos-mendez@grafana.com>
Co-authored-by: Franco Posa <franco.posa@grafana.com>

* move readTsdb to parquet storage sub-package; rename method & vars for clarity & testability (#11222)

* move readTsdb to parquet storage sub-package; rename method & vars for clarity

* add license header

* Parquet: Initialize parquet converter module (#11226)

* Initialize parquet compactor module

Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com>

* Rename to parquet converter

Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com>

* Implement allowlist

* fix reader tests

* Update docs

* also skip disallowed tenants when converting blocks

* fix initialization of allowedTenants

* various name changes

---------

Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com>
Co-authored-by: Nicolás Pazos <npazosmendez@gmail.com>

---------

Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com>
Co-authored-by: Nico Pazos <nicolas.pazos-mendez@grafana.com>
Co-authored-by: Franco Posa <franco.posa@grafana.com>
Co-authored-by: Franco Posa <franco@francoposa.io>
Co-authored-by: Nicolás Pazos <npazosmendez@gmail.com>
jesusvazquez added a commit that referenced this pull request Apr 21, 2025
* Parquet converter

Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com>
Co-authored-by: Nico Pazos <nicolas.pazos-mendez@grafana.com>
Co-authored-by: Franco Posa <franco.posa@grafana.com>

* move readTsdb to parquet storage sub-package; rename method & vars for clarity & testability (#11222)

* move readTsdb to parquet storage sub-package; rename method & vars for clarity

* add license header

* Parquet: Initialize parquet converter module (#11226)

* Initialize parquet compactor module

Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com>

* Rename to parquet converter

Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com>

* Implement allowlist

* fix reader tests

* Update docs

* also skip disallowed tenants when converting blocks

* fix initialization of allowedTenants

* various name changes

---------

Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com>
Co-authored-by: Nicolás Pazos <npazosmendez@gmail.com>

---------

Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com>
Co-authored-by: Nico Pazos <nicolas.pazos-mendez@grafana.com>
Co-authored-by: Franco Posa <franco.posa@grafana.com>
Co-authored-by: Franco Posa <franco@francoposa.io>
Co-authored-by: Nicolás Pazos <npazosmendez@gmail.com>
francoposa added a commit that referenced this pull request Apr 23, 2025
* Parquet converter

Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com>
Co-authored-by: Nico Pazos <nicolas.pazos-mendez@grafana.com>
Co-authored-by: Franco Posa <franco.posa@grafana.com>

* move readTsdb to parquet storage sub-package; rename method & vars for clarity & testability (#11222)

* move readTsdb to parquet storage sub-package; rename method & vars for clarity

* add license header

* Parquet: Initialize parquet converter module (#11226)

* Initialize parquet compactor module

Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com>

* Rename to parquet converter

Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com>

* Implement allowlist

* fix reader tests

* Update docs

* also skip disallowed tenants when converting blocks

* fix initialization of allowedTenants

* various name changes

---------

Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com>
Co-authored-by: Nicolás Pazos <npazosmendez@gmail.com>

---------

Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com>
Co-authored-by: Nico Pazos <nicolas.pazos-mendez@grafana.com>
Co-authored-by: Franco Posa <franco.posa@grafana.com>
Co-authored-by: Franco Posa <franco@francoposa.io>
Co-authored-by: Nicolás Pazos <npazosmendez@gmail.com>
jesusvazquez added a commit that referenced this pull request Apr 24, 2025
* Parquet converter

Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com>
Co-authored-by: Nico Pazos <nicolas.pazos-mendez@grafana.com>
Co-authored-by: Franco Posa <franco.posa@grafana.com>

* move readTsdb to parquet storage sub-package; rename method & vars for clarity & testability (#11222)

* move readTsdb to parquet storage sub-package; rename method & vars for clarity

* add license header

* Parquet: Initialize parquet converter module (#11226)

* Initialize parquet compactor module

Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com>

* Rename to parquet converter

Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com>

* Implement allowlist

* fix reader tests

* Update docs

* also skip disallowed tenants when converting blocks

* fix initialization of allowedTenants

* various name changes

---------

Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com>
Co-authored-by: Nicolás Pazos <npazosmendez@gmail.com>

---------

Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com>
Co-authored-by: Nico Pazos <nicolas.pazos-mendez@grafana.com>
Co-authored-by: Franco Posa <franco.posa@grafana.com>
Co-authored-by: Franco Posa <franco@francoposa.io>
Co-authored-by: Nicolás Pazos <npazosmendez@gmail.com>
jesusvazquez added a commit that referenced this pull request May 2, 2025
* Parquet converter

Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com>
Co-authored-by: Nico Pazos <nicolas.pazos-mendez@grafana.com>
Co-authored-by: Franco Posa <franco.posa@grafana.com>

* move readTsdb to parquet storage sub-package; rename method & vars for clarity & testability (#11222)

* move readTsdb to parquet storage sub-package; rename method & vars for clarity

* add license header

* Parquet: Initialize parquet converter module (#11226)

* Initialize parquet compactor module

Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com>

* Rename to parquet converter

Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com>

* Implement allowlist

* fix reader tests

* Update docs

* also skip disallowed tenants when converting blocks

* fix initialization of allowedTenants

* various name changes

---------

Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com>
Co-authored-by: Nicolás Pazos <npazosmendez@gmail.com>

---------

Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com>
Co-authored-by: Nico Pazos <nicolas.pazos-mendez@grafana.com>
Co-authored-by: Franco Posa <franco.posa@grafana.com>
Co-authored-by: Franco Posa <franco@francoposa.io>
Co-authored-by: Nicolás Pazos <npazosmendez@gmail.com>
francoposa added a commit that referenced this pull request May 7, 2025
* Parquet converter

Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com>
Co-authored-by: Nico Pazos <nicolas.pazos-mendez@grafana.com>
Co-authored-by: Franco Posa <franco.posa@grafana.com>

* move readTsdb to parquet storage sub-package; rename method & vars for clarity & testability (#11222)

* move readTsdb to parquet storage sub-package; rename method & vars for clarity

* add license header

* Parquet: Initialize parquet converter module (#11226)

* Initialize parquet compactor module

Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com>

* Rename to parquet converter

Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com>

* Implement allowlist

* fix reader tests

* Update docs

* also skip disallowed tenants when converting blocks

* fix initialization of allowedTenants

* various name changes

---------

Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com>
Co-authored-by: Nicolás Pazos <npazosmendez@gmail.com>

---------

Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com>
Co-authored-by: Nico Pazos <nicolas.pazos-mendez@grafana.com>
Co-authored-by: Franco Posa <franco.posa@grafana.com>
Co-authored-by: Franco Posa <franco@francoposa.io>
Co-authored-by: Nicolás Pazos <npazosmendez@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0