querier: improve e2e tests for error parsing #11369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing test wasn't catching a bug (XXX) because 1) it was only querying a single store-gateway and 2) blocks were returning disjoin series. This PR improves the test suite to make it more realistic: - 3 ingesters instead of 2 - 3 store-gateways instead of 1 - overlapping series in each block > _In draft until the prometheus PR is merged and vendored in Mimir. The test will fail until then._ Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
|
marking this as ready for review as we've received the fix from upstream |
There was a problem hiding this comment.
Pull Request Overview
This PR improves end-to-end tests for error parsing by updating the test environment to simulate a realistic scenario with multiple ingesters and store gateways. Key changes include:
- Replacing a single ingester with three ingesters.
- Adding a new constant for the number of series per block and updating series generation.
- Adjusting querier and store-gateway flags and client creation to better simulate error conditions.
Comments suppressed due to low confidence (1)
integration/store_gateway_limits_hit_test.go:77
- [nitpick] The loop variable 'j' could be renamed to a more descriptive name (e.g., 'seriesIndex') to improve code clarity.
for j := 0; j < numSeriesPerBlock; j++ {
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
The existing test wasn't catching a bug (prometheus/prometheus#16544) because 1) it was only querying a single store-gateway and 2) blocks were returning disjoin series.
This PR improves the test suite to make it more realistic:
Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.