8000 Fix doc: -distributor.otel-promote-resource-attributes wrong spelling by ouyuran · Pull Request #11450 · grafana/mimir · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix doc: -distributor.otel-promote-resource-attributes wrong spelling #11450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2025

Conversation

ouyuran
Copy link
Contributor
@ouyuran ouyuran commented May 13, 2025

What this PR does

The experimental flag -distributor.otel-promote-resource-attributes is wrongly spelled as -distributor.promote-otel-resource-attributes in a few documents.

Which issue(s) this PR fixes or relates to

Fixes

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@ouyuran ouyuran requested review from tacole02 and a team as code owners May 13, 2025 02:54
@CLAassistant
Copy link
CLAassistant commented May 13, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor
@56quarters 56quarters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ouyuran
Copy link
Contributor Author
ouyuran commented May 14, 2025

@56quarters some CI jobs failed, how should I get ride of it?

Copy link
Contributor
@aknuds1 aknuds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@aknuds1
Copy link
Contributor
aknuds1 commented May 14, 2025

some CI jobs failed, how should I get ride of it?

@ouyuran Can you merge mimir/main into your branch and push? Maybe that will fix it.

@56quarters 56quarters merged commit 20d506e into grafana:main May 14, 2025
29 of 30 checks passed
56quarters pushed a commit that referenced this pull request May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0