8000 MQE: Include chunks loaded from ingesters in memory estimate by 56quarters · Pull Request #11457 · grafana/mimir · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

MQE: Include chunks loaded from ingesters in memory estimate #11457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2025
Merged

MQE: Include chunks loaded from ingesters in memory estimate #11457

merged 1 commit into from
May 16, 2025

Conversation

56quarters
Copy link
Contributor
@56quarters 56quarters commented May 14, 2025 •
edited
Loading

What this PR does

Include chunks streamed from ingesters that are currently in memory
in the MQE memory usage estimate. The memory tracker for the current
query is propagated through the read path using the context for the
current request.

Which issue(s) this PR fixes or relates to

Related #11453

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@56quarters 56quarters force-pushed the 56quarters/chunk-memory-tracking-redux branch from 8869c19 to 5f95f17 Compare May 14, 2025 17:08
@56quarters 56quarters force-pushed the 56quarters/chunk-memory-tracking-redux-ingester branch 3 times, most recently from 43862cc to a8c96be Compare May 15, 2025 16:30
@56quarters 56quarters force-pushed the 56quarters/chunk-memory-tracking-redux branch from 5dd21be to 008a9e4 Compare May 15, 2025 16:43
@56quarters 56quarters force-pushed the 56quarters/chunk-memory-tracking-redux-ingester branch from a8c96be to eb43535 Compare May 15, 2025 16:45
Base automatically changed from 56quarters/chunk-memory-tracking-redux to main May 15, 2025 17:15
@56quarters 56quarters force-pushed the 56quarters/chunk-memory-tracking-redux-ingester branch from eb43535 to 26e6174 Compare May 15, 2025 17:16
@56quarters 56quarters marked this pull request as ready for review May 15, 2025 17:54
@56quarters 56quarters requested a review from a team as a code owner May 15, 2025 17:54
@56quarters 56quarters force-pushed the 56quarters/chunk-memory-tracking-redux-ingester branch from 26e6174 to 32d18e6 Compare May 15, 2025 17:56
charleskorn
charleskorn approved these changes May 16, 2025
View reviewed changes
Copy link
Contributor
@charleskorn charleskorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@56quarters
MQE: Include chunks loaded from ingesters in memory estimate
47a4b1b 
Include chunks streamed from ingesters that are currently in memory
in the MQE memory usage estimate. The memory tracker for the current
query is propagated through the read path using the context for the
current request.

Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
@56quarters 56quarters force-pushed the 56quarters/chunk-memory-tracking-redux-ingester branch from 32d18e6 to 47a4b1b Compare May 16, 2025 14:11
@56quarters 56quarters closed this May 16, 2025
@56quarters 56quarters reopened this May 16, 2025
@56quarters 56quarters merged commit dd194e6 into main May 16, 2025
59 checks passed
@56quarters 56quarters deleted the 56quarters/chunk-memory-tracking-redux-ingester branch May 16, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charleskorn charleskorn charleskorn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@56quarters @charleskorn
0