bring in prometheus/parquet-common code to new package #11490
Conversation
There was a problem hiding this comment.
I think it would be preferable to use Renovate's PRs for updating objstore (you can patch this PR with your fixes) and cloud.google.com/go/storage. Plus, I don't think this PR should be removing the toolchain directive and its explanatory comment.
| func TestPromQLAcceptance(t *testing.T) { | ||
| if testing.Short() { | ||
| t.Skip("Skipping, because 'short' flag was set") | ||
| } |
There was a problem hiding this comment.
This test took ~15min in the CI. Is that a concern? Do we want to make it opt-in rather than opt-out? I'm mostly thinking about the impact on other mimir devs, not us
There was a problem hiding this comment.
Our CI health is already pretty terrible. This should be opt-in, 15m is a non-starter.
There was a problem hiding this comment.
It's fixed already to be opt-in with env var
…ient-go errors with pkg/errors; satisfy mimir-prometheus ChunkSeries interface
fix errors.Is lints
276779b to
56fa1e6
Compare
|
@aknuds1 The toolchain directive came back anyway when I copied over the go.mod from main to fix conflicts, so we should be good to go I also used the env var approach to prevent the super long PromQL acceptance tests from running in CI |
* bring in prometheus/parquet-common code to new package; replace efficient-go errors with pkg/errors; satisfy mimir-prometheus ChunkSeries interface * revert breaking upgrade to thanos/objstore * fix test require * attempt to update go version for strange errors * fix stringlabels issues * update license headers with AGPL and upstream attribution * fix errors.Is lints fix errors.Is lints * fix sort and cancel cause lints * correct go.mod & vendor in from main to solve conflicts * use env var to flag parquet promql acceptance * fix deps from main again * fix deps from main again * fix deps from main again * fix deps from main again
* bring in prometheus/parquet-common code to new package; replace efficient-go errors with pkg/errors; satisfy mimir-prometheus ChunkSeries interface * revert breaking upgrade to thanos/objstore * fix test require * attempt to update go version for strange errors * fix stringlabels issues * update license headers with AGPL and upstream attribution * fix errors.Is lints fix errors.Is lints * fix sort and cancel cause lints * correct go.mod & vendor in from main to solve conflicts * use env var to flag parquet promql acceptance * fix deps from main again * fix deps from main again * fix deps from main again * fix deps from main again
This approach is being taken so as we iterate in dev we do not have to maintain an enormous branch and constantly rebase.
I believe this structure for the dependency code is least likely to cause us import cycles, whether we put the converter as a subpackage of
pkg/parquetor standing completely on its own.In any case, we can always adjust.
patches w.r.t upstream:
ChunkSeriesinterface withChunkCountmethodrequire.Lenfor alabels.Labelsnot satisfyinglen()builtin - I believe this is astringlabels/slicelabelsissuestringlabels/slicelabelsfixes==error comparisons witherrors.Issort.Stringsusages withslices.Sortcontext.WithCancelCauseWhat this PR does
Brings in code from https://github.com/prometheus-community/parquet-common @ commit 382b6ec8 into a new package.
No new components or services utilized yet - nothing new deployed.
Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.