Upgrade to latest gRPC and latest dskit #11492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the project's dependencies to use the latest versions of gRPC (v1.72.1) and dskit (commit 78afbb506eb9) to ensure compatibility between dskit and gRPC.
- Updated dskit version from v0.0.0-20250508185919-68d09ac9016e to v0.0.0-20250519165046-78afbb506eb9
- Upgraded gRPC from v1.71.1 to v1.72.1
- Removed the exclusion for gRPC v1.72.0, allowing adoption of the new version
Comments suppressed due to low confidence (2)
go.mod:53
- Ensure that the upgrade to gRPC v1.72.1 is thoroughly tested across all gRPC consumers in the project to catch any compatibility issues with newer API behaviors.
google.golang.org/grpc v1.72.1
go.mod:347
- The removal of the exclusion for gRPC v1.72.0 is appropriate, but confirm that all downstream integrations have been validated against this new version.
exclude google.golang.org/grpc v1.72.0
andyasp
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Upgrade to gRPC@v1.72.1 (from v1.71.1) and latest dskit main (78afbb506eb9). We have to upgrade to gRPC v1.72 since the latest dskit revision depends on it.
The latest dskit revision only takes care of upgrading to gRPC v1.72, via grafana/dskit#689. I can't see any major differences in gRPC from v1.71.1 -> v1.72.1.
Which issue(s) this PR fixes or relates to
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.