8000 Block-builder: Gracefully shutdown pull-mode worker. by seizethedave · Pull Request #11513 · grafana/mimir · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Block-builder: Gracefully shutdown pull-mode worker. #11513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 23, 2025
Merged

Block-builder: Gracefully shutdown pull-mode worker. #11513

merged 4 commits into from
May 23, 2025

Conversation

seizethedave
Copy link
Contributor
@seizethedave seizethedave commented May 22, 2025 •
edited
Loading

What this PR does

Which issue(s) this PR fixes or relates to

This change allows an assigned job to finish processing when the service's context is canceled.

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@seizethedave seizethedave marked this pull request as ready for review May 22, 2025 21:38
@seizethedave seizethedave requested a review from a team as a code owner May 22, 2025 21:38
narqo
narqo approved these changes May 23, 2025
View reviewed changes
Copy link
Contributor
@narqo narqo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Thank you

@seizethedave seizethedave merged commit a481845 into main May 23, 2025
30 checks passed
@seizethedave seizethedave deleted the davidgrant/bb-graceful branch May 23, 2025 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narqo narqo narqo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seizethedave @narqo
0