Fix issue where a query containing a common subexpression that returned an error could also panic with integer divide by zero
#11514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed an error could also panic with `integer divide by zero`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR fixes an issue where a query containing a common subexpression that returned an error could also panic with
integer divide by zerowhen the query was closed.This would occur if:
NextSeriescall were closed before the firstNextSeriescallerIf these conditions were met,
SeriesDataRingBuffer.Removewould panic when evaluatingb.startIndex % len(b.data).As the query was closed after the HTTP response was sent, the user still saw the expected error message, but the querier would have crashed and restarted, so other inflight queries may have been affected.
Which issue(s) this PR fixes or relates to
#11189
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.