ingest: fix flaky TestPartitionReader_ConsumeAtStartup test after franz-go update #11527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix TestPartitionReader_ConsumeAtStartup test that was failing due to changes in franz-go's retry behavior. After the franz-go update (fac21aa), EOF errors on the first read are no longer retried. The test mock now returns proper Kafka error responses (NotLeaderForPartition) instead of raw errors to ensure franz-go will retry as expected. Also improved the coordination between context cancellation and mock responses using atomic boolean to make subsequent requests fail faster. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
narqo
approved these changes
May 26, 2025
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
TestPartitionReader_ConsumeAtStartuptest that was failing due to changes in franz-go's retry behavior. After the franz-go update (#11467, fac21aa), EOF errors on the first read are no longer retried. This PR is similar to #11467.The test mock now returns proper Kafka error responses (NotLeaderForPartition) instead of raw errors to ensure franz-go will retry as expected. Also improved the coordination between context cancellation and mock responses using atomic boolean to make subsequent requests fail faster.
What this PR does
Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.