8000 query-frontend: add retry logic for cardinality, series and remoteReads endpoints by NickAnge · Pull Request #11533 · grafana/mimir · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

query-frontend: add retry logic for cardinality, series and remoteReads endpoints #11533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 27, 2025
Merged

query-frontend: add retry logic for cardinality, series and remoteReads endpoints #11533

merged 6 commits into from
May 27, 2025

Conversation

NickAnge
Copy link
Contributor
@NickAnge NickAnge commented May 26, 2025 •
edited
Loading

What this PR does

In this PR we extend retry.go to support retryLogic fro RoundTripper, in order to add it for cardinality and series endpoints.

Which issue(s) this PR fixes or relates to

Fixes #370

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@NickAnge NickAnge changed the title add retry roundTripper query-frontend: add retry logic for cardinality, series and remoteReads endpoints May 26, 2025
NickAnge
NickAnge commented May 26, 2025
View reviewed changes
@NickAnge NickAnge marked this pull request as ready for review May 26, 2025 12:35
@NickAnge NickAnge requested a review from a team as a code owner May 26, 2025 12:35
dimitarvdimitrov
dimitarvdimitrov reviewed May 26, 2025
View reviewed changes
@NickAnge NickAnge force-pushed the nickange/query/add-RoundTripper-retry branch from 740b777 to b6e5249 Compare May 26, 2025 15:45
@NickAnge NickAnge requested a review from dimitarvdimitrov May 26, 2025 16:22
tacole02
tacole02 approved these changes May 26, 2025
View reviewed changes
charleskorn
charleskorn reviewed May 27, 2025
View reviewed changes
Copy link
Contributor
@charleskorn charleskorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed something very minor:

@NickAnge NickAnge requested a review from charleskorn May 27, 2025 07:59
dimitarvdimitrov
dimitarvdimitrov approved these changes May 27, 2025
View reviewed changes
Copy link
Contributor
@dimitarvdimitrov dimitarvdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one, LGTM!

@NickAnge NickAnge merged commit 95ab933 into main May 27, 2025
30 checks passed
@NickAnge NickAnge deleted the nickange/query/add-RoundTripper-retry branch May 27, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charleskorn charleskorn charleskorn approved these changes

@dimitarvdimitrov dimitarvdimitrov dimitarvdimitrov approved these changes

@tacole02 tacole02 tacole02 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NickAnge @charleskorn @dimitarvdimitrov @tacole02
0