This repository was archived by the owner on Dec 26, 2022. It is now read-only.
Resolves #246 - replaces dgraph-rs with dgraph-tonic in graph-merger #251
8000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colin-grapl
approved these changes
Sep 17, 2020
|
@d0nut-grapl are you sure the those tests cover this code? I'm not too familiar with them, but if not I'd prefer we test manually (ex: localgrapl) by running data through before merge. |
Ahh I finally was able to take a look at what all of our testing covers, and we should probably do a manual test :P Mind helping me set that up today? @inickles-grapl Regardless, it looks like I need to remerge staging back into this branch first. |
Sure 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR correspond to?
#246
What changes does this PR make to Grapl? Why?
Updated graph-merger to use dgraph-tonic instead of dgraph-rs to get the benefit of not needing to maintain a dgraph client library when a good alternative exists.
How were these changes tested?
dobi rust-unit-testsanddobi rust-integration-testsboth passed. Any likely important issue with this code that would've surfaced in this port would've been teased out by the integration tests.