This repository was archived by the owner on Dec 26, 2022. It is now read-only.
Remove grapl-graph-descriptions dep rename in libs used by generators #304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graph-descriptions for libraries used by plugins: derive-dynamic-node and graph-generator-lib. This should remove the requirement that plugins would need to make the same rename in their Cargo.toml.
…so clearing out some unused imports.
colin-grapl
approved these changes
Sep 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes does this PR make to Grapl? Why?
The derive-dynamic-node lib implements macros to be used by generators, and those macros include paths to a renamed grapl-graph-descriptions path, which requires generators to rename the dependency in their Cargo.toml. This requirement is not obvious and seems unnecessary. This PR removes that requirement, yet still allows generators to rename if they want to.
How were these changes tested?
Rebuilt grapl and plugin, uploaded analyzer test data and verified in sagemaker that the nodes look good. 👍