8000 feat: add "done" state to visualization by martingregoire · Pull Request #165 · greeny/SatisfactoryTools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: add "done" state to visualization #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

martingregoire
Copy link
@martingregoire martingregoire commented Oct 3, 2024

Description

Allows to mark nodes in the visualization as "done" by double-clicking on them. A "done" node will be shown with a green background.

Double-clicking on a "done" node will reset them to their initial state.

Note: this "done" state is not persisted in LocalStorage, it is only saved in the visualization state. This means that if you e.g. reload the page, all nodes will loose their "done" state.

Demo

This is how it looks like:

sft-done-state.webm

@martingregoire
Copy link
Author

Hi @greeny, thanks a lot for your awesome Satisfactory Tools! ❤️ I've been using them all the time to plan my factories.

One thing that I'm missing is the possibility to mark parts of a factory as "done" while building it. A different tool allows this by clicking a node, so I tried to implement something similar here.

Would be nice if you could have a look and leave some feedback. 🙂

@greeny
Copy link
Owner
greeny commented Oct 3, 2024

The problem with this is that tabbing to another production line resets the "done" state (and refreshing does as well).

Refreshing would need saving the state, which is too much work, but it would be nice for the done state to persist between switching tabs at least.

Also, I'd prefer the nodes to not change color, but rather go to some "less opaque state" and keep their original color (that's how it worked before anyway).

@martingregoire
Copy link
Author

Yes I see your point, I'll try to move the "done" state further up, so it will be kept when switching production lines. 👍

Allows to mark nodes in the visualization as "done" by double-clicking
on them. A "done" node will be shown with a green background.

Double-clicking on a "done" node will reset them to their initial state.

Note: this "done" state is not persisted in LocalStorage, it is only
saved in the visualization state. This means that if you e.g. reload the
page, all nodes will loose their "done" state.
@martingregoire martingregoire force-pushed the feat/add-done-state-to-visualization branch from 9d596e1 to 2ca44f2 Compare October 3, 2024 11:58
@martingregoire
Copy link
Author
martingregoire commented Oct 3, 2024

Updated the PR (and demo video) - please check again @greeny. 🙂

The "done" state is now in the GraphNode, so it is persisted when switching between production lines.

Also the node boxes will now change their opacity when "done" (to a value of 0.2 that I found somewhere in the code), instead of changing their background color.

WDYT?

@laurensvc
Copy link

Came here to add the same feature but saw there was already a branch and pr made :)
Please review if you have the time @greeny
Also, thanks for all the work on SFT!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0