8000 [WIP] First step of moving into ngx by kptLucek · Pull Request #49 · greeny/SatisfactoryTools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[WIP] First step of moving into ngx #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
8000 wants to merge 13 commits into
base: dev
Choose a base branch
from
Draft

[WIP] First step of moving into ngx #49

wants to merge 13 commits into from

Conversation

kptLucek
Copy link
Collaborator
@kptLucek kptLucek commented Dec 7, 2020 •
edited
Loading

This is WIP of first step in order to replace old (and unsupported) AngularJS based app into Angular (current target is ~10)

  • Codex reworked
    • Items
      • Browsing each
      • Search with filters
    • Buildings
      • Browsing each
      • Search with filters
    • Schematic
      • Browsing each
      • Search with filters
  • Calculator reworked
    • Changing tab name
    • Changing tab icon
    • Production tab
      • Adding products
      • Removing products
      • Cloning products
      • Clearing whole production tab
      • Sorting products
    • Items / inputs tab
      • Changing each resource values
      • S 8000 etting resource values to 0
      • Reseting resource values back to map's default
      • Adding input products
      • Removing input products
      • Cloning input products
      • Sorting input products
    • Recipes tab
  • Fixing CSS compared to old-version
  • Navigation reworked
  • Working with LocalStorage, along with previously saved data
  • AngularJS is gone
  • jQuery is gone
  • PHP is no longer needed to work with
  • Fontawesome goes from node_modules

This PR is not intended to provide best-looking-code-ever, it's top priority is to upgrade app's core int newer version of angular while maitaining app functionality.

@kptLucek kptLucek added this to the NGX milestone Dec 7, 2020
@kptLucek kptLucek added the improvement Improvement for the codebase, i.e. refactoring, new feature label Dec 8, 2020
@greeny
Copy link
Owner
greeny commented Dec 8, 2020

I'd mark "jQuery is gone" as optional/part of next PR, since jQuery is required for bootstrap, so that would mean we have to change bootstrap to some alternative as well, which is not required for angularJS > angular migration.

@kptLucek
Copy link
Collaborator Author
kptLucek commented Dec 8, 2020

I'd mark "jQuery is gone" as optional/part of next PR, since jQuery is required for bootstrap, so that would mean we have to change bootstrap to some alternative as well, which is not required for angularJS > angular migration.

In this case no, jQuery is not required by any dependency afaik, and bootstrap got replaced by bootstrap-scss which contains scss only :)

@greeny greeny mentioned this pull request May 15, 2021
Closed
@greeny greeny marked this pull request as draft August 23, 2021 10:07
@greeny greeny added New Tools This one will be handled in new Tools, a completely separate project that is currently being written and removed improvement Improvement for the codebase, i.e. refactoring, new feature labels Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@greeny greeny

Labels
New Tools This one will be handled in new Tools, a completely separate project that is currently being written
Projects
None yet
Milestone
NGX
Development

Successfully merging this pull request may close these issues.
2 participants
@kptLucek @greeny
0