8000 new setColumn() heuristics by adumesny · Pull Request #1098 · gridstack/gridstack.js · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

new setColumn() heuristics #1098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 19, 2019
Merged

new setColumn() heuristics #1098

merged 2 commits into from
Dec 19, 2019

Conversation

adumesny
Copy link
Member

Description

  • complete re-write of the setColumn() code that moves/sizes widgets.
    we now do a reasonable job positioning widgets (especially 1 column), and
    we remember positions for each column layout to going from 12 -> 1 -> 12
    will bring it exactly back for example!
  • new column.html test case (now that it works) to be published.
  • fixed bunch of bugs I found with overlapping widgets (going to 2 or 1 column)
  • fixed bug where default (empty) option when adding a widget would render it at (0,0)
    overlapping any existing widgets. added readAttr()/_writeAttr() to help there.
  • unit test greatly updated with exact location expected of widgets (not that I agree with location)

better fix than #809

fixing responsive.html will come next...

Checklist

  • Created tests which fail without the change (if possible)
  • All tests passing (yarn test)
  • Extended the README / documentation, if necessary

new setColumn() heuristics
1c5bc14 
* complete re-write of the `setColumn()` code that moves/sizes widgets.
we now do a reasonable job positioning widgets (especially 1 column), and
we remember positions for each column layout to going from 12 -> 1 -> 12
will bring it exactly back for example!
* new column.html test case (now that it works) to be published.
* fixed bunch of bugs I found with overlapping widgets (going to 2 or 1 column)
* fixed bug where default (empty) option when adding a widget would render it at (0,0)
overlapping any existing widgets. added `_readAttr()/_writeAttr()` to help there.
* unit test greatly updated with exact location expected of widgets (not that I agree with location)

better fix than #809

fixing responsive.html will come next...
@adumesny adumesny closed this Dec 19, 2019
@adumesny adumesny reopened this Dec 19, 2019
@coveralls
Copy link
coveralls commented Dec 19, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.4%) to 67.081% when pulling 1f9560d on adumesny:develop into 5035a18 on gridstack:develop.

@adumesny adumesny mentioned this pull request Dec 19, 2019
Closed
@adumesny adumesny merged commit e2369cf into gridstack:develop Dec 19, 2019
This was referenced Dec 19, 2019
Closed
Closed
Closed
Merged
Merged
Closed
Closed
This was referenced Feb 2, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adumesny @coveralls
0