8000 Noam/core 5552 cli should use new ingestion keys by noamApps · Pull Request #318 · groundcover-com/cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Noam/core 5552 cli should use new ingestion keys 8000 #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 9, 2025

Conversation

noamApps
Copy link
Collaborator
@noamApps noamApps commented Jul 9, 2025

Summary by CodeRabbit

  • Refactor
    • Updated ingestion key naming to use lowercase formatting for consistency.

noamApps added 4 commits July 8, 2025 02:01
- Introduced a new command `get-ingestion-key` to retrieve or create an ingestion key using the Groundcover SDK.
- Updated Go version in Earthfile and go.mod to 1.24.
- Added new dependencies including `github.com/groundcover-com/groundcover-sdk-go` v1.34.0 and various `go-openapi` packages.
- Enhanced client functionality with a custom transport to include tenant UUID in requests.
- Updated the `get-ingestion-key` command to require an ingestion key type as an argument.
- Modified the `getOrCreateIngestionKey` function to use the provided key type for generating the ingestion key name.
- Improved error handling to ensure the key type is specified before proceeding.
- Updated the `getOrCreateIngestionKey` function to convert the generated ingestion key name to lowercase for consistency.
- This change ensures that the ingestion key names are uniformly formatted, improving usability and reducing potential errors.
@noamApps noamApps requested a review from nitzangr July 9, 2025 13:28
Copy link
coderabbitai bot commented Jul 9, 2025

Walkthrough

The update changes how ingestion key names are generated in the getOrCreateIngestionKey function by converting the key type to lowercase before formatting the string. Only the string construction is affected; all other logic remains unchanged.

Changes

File(s) Change Summary
cmd/ingestion_key.go Imports strings package; updates key name construction to use lowercase for the key type.

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant IngestionKeyManager

    Caller->>IngestionKeyManager: getOrCreateIngestionKey(type)
    IngestionKeyManager->>IngestionKeyManager: keyName = format(constant, toLower(type))
    IngestionKeyManager->>IngestionKeyManager: list existing keys with keyName
    alt Key exists
        IngestionKeyManager-->>Caller: return existing key
    else Key does not exist
        IngestionKeyManager->>IngestionKeyManager: create new key with keyName
        IngestionKeyManager-->>Caller: return new key
    end
Loading
✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbi 8000 t configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8991381 and e8e8251.

📒 Files selected for processing (1)
  • cmd/ingestion_key.go (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: goreleaser
  • GitHub Check: Analyze (go)
  • GitHub Check: Analyze (actions)
🔇 Additional comments (1)
cmd/ingestion_key.go (1)

6-6: Import addition is correct.

Necessary for the strings.ToLower() functionality.

@noamApps noamApps merged commit 855fa49 into main Jul 9, 2025
5 checks passed
@noamApps noamApps deleted the noam/core-5552-cli-should-use-new-ingestion-keys branch July 9, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0