8000 Sprite offset and texture mapping by GDQR · Pull Request #154 · h4570/tyra · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Sprite offset and texture mapping #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 29, 2023
Merged

Sprite offset and texture mapping #154

merged 5 commits into from
May 29, 2023

Conversation

GDQR
Copy link
Contributor
@GDQR GDQR commented May 28, 2023

Allows you to create an offset in the sprite and show only a part of the original image, useful for sprite sheets.
Allows you to select the texture mapping (Nearest or Linear) for renderer 2D.
Includes a tutorial.

GDQR added 2 commits May 26, 2023 18:04
@GDQR
tutorial 10
fbcb38d
@GDQR
new Tutorial
4f6e55c 
tutorial with sprite offset, sprite sheet and texture filtering
@GDQR GDQR closed this May 28, 2023
@GDQR GDQR reopened this May 28, 2023
Wolf3s
Wolf3s suggested changes May 28, 2023
View reviewed changes
@h4570
Copy link
Owner
h4570 commented May 28, 2023 •
edited
Loading

Hello!

Thank you so much for contributing.
So.. from now, we have font support in Tyra 😄.
I added some fixes to your PR, please check if I didn't broke anything and respond to this comment.
After your confirmation, I will merge this PR and add new assets to release zip file

h4570
h4570 reviewed May 28, 2023
View reviewed changes
tutorials/10-sprite-sheet/src/font_sprite.cpp

namespace Tyra {

const int Font::chars[FONT_CHAR_SIZE]{
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed some letters, because of:

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine, no problem

@GDQR
Copy link
Contributor Author
GDQR commented May 28, 2023

XD I was just trying to make a commit, I just found out what the clang format is, I had some problems but don't worry I already fixed it.
By the way, I made the font simple and so that it would only be used for this tutorial and give others an idea to create their own font, that's why I put it in a class, otherwise I would have made it global, it doesn't bother me anyway.

@GDQR
Copy link
Contributor Author
GDQR commented May 28, 2023

Hello!

Thank you so much for contributing. So.. from now, we have font support in Tyra 😄. I added some fixes to your PR, please check if I didn't broke anything and respond to this comment. After your confirmation, I will merge this PR and add new assets to release zip file

I'm quoting this right now XD, sorry, I'm new to contributing projects.

@Wolf3s
Copy link
Contributor
Wolf3s commented May 28, 2023

Hello!
Thank you so much for contributing. So.. from now, we have font support in Tyra 😄. I added some fixes to your PR, please check if I didn't broke anything and respond to this comment. After your confirmation, I will merge this PR and add new assets to release zip file

I'm quoting this right now XD, sorry, I'm new to contributing projects.

Ok, at least you can learn here.

@GDQR
Copy link
Contributor Author
GDQR commented May 28, 2023

Hello!
Thank you so much for contributing. So.. from now, we have font support in Tyra smile. I added some fixes to your PR, please check if I didn't broke anything and respond to this comment. After your confirmation, I will merge this PR and add new assets to release zip file

I'm quoting this right now XD, sorry, I'm new to contributing projects.

Ok, at least you can learn here.

yeah, i hope i can contribute more to tyra.

@Wolf3s
Copy link
Contributor
Wolf3s commented May 28, 2023

Hello!

Thank you so much for contributing. So.. from now, we have font support in Tyra 😄. I added some fixes to your PR, please check if I didn't broke anything and respond to this comment. After your confirmation, I will merge this PR and add new assets to release zip file

Lgtm commit.

@Wolf3s
Copy link
Contributor
Wolf3s commented May 28, 2023

Hello!
Thank you so much for contributing. So.. from now, we have font support in Tyra smile. I added some fixes to your PR, please check if I didn't broke anything and respond to this comment. After your confirmation, I will merge this PR and add new assets to release zip file

I'm quoting this right now XD, sorry, I'm new to contributing projects.

Ok, at least you can learn here.

yeah, i hope i can contribute more to tyra.

Be welcome.

@h4570 h4570 merged commit e63ae14 into h4570:master May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wolf3s Wolf3s Wolf3s requested changes

@h4570 h4570 h4570 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GDQR @h4570 @Wolf3s
0