fix width of `AffinitPanel` #13

bertwesarg · 2020-08-26T20:04:37Z

The panel size of 15 includes the gap to the next panel, thus use 14 as
the minimum size and let the caller of AffinityPanel_new handle the
gap.

The panel size of 15 includes the gap to the next panel, thus use 14 as the minimum size and let the caller of `AffinityPanel_new` handle the gap.

The signal handler will access the Settings struct, which gets freed at normal program finalization. When using leak sanitizers with ASAN_OPTIONS=abort_on_error=1, which runs after program termination, any leak causes SIGABRT to be raised, calling the crash handler, which will derefernce the freed Settings. ==44741==ERROR: AddressSanitizer: heap-use-after-free on address 0x60d000000080 at pc 0x0000005680df bp 0x7fffe335e960 sp 0x7fffe335e958 READ of size 8 at 0x60d000000080 thread T0 #0 0x5680de in Settings_write /home/christian/Coding/workspaces/htop/Settings.c:329:26 #1 0x4f77b7 in CRT_handleSIGSEGV /home/christian/Coding/workspaces/htop/CRT.c:1020:4 #2 0x7f8a1120c13f (/lib/x86_64-linux-gnu/libpthread.so.0+0x1413f) htop-dev#3 0x7f8a11042ce0 in __libc_signal_restore_set signal/../sysdeps/unix/sysv/linux/internal-signals.h:86:3 htop-dev#4 0x7f8a11042ce0 in raise signal/../sysdeps/unix/sysv/linux/raise.c:48:3 htop-dev#5 0x7f8a1102c536 in abort stdlib/abort.c:79:7 htop-dev#6 0x4c3db6 in __sanitizer::Abort() (/home/christian/Coding/workspaces/htop/htop+0x4c3db6) htop-dev#7 0x4c2090 in __sanitizer::Die() (/home/christian/Coding/workspaces/htop/htop+0x4c2090) htop-dev#8 0x4d0a17 in __lsan::HandleLeaks() (/home/christian/Coding/workspaces/htop/htop+0x4d0a17) htop-dev#9 0x4cd950 in __lsan::DoLeakCheck() (/home/christian/Coding/workspaces/htop/htop+0x4cd950) htop-dev#10 0x7f8a110454d6 in __run_exit_handlers stdlib/exit.c:108:8 htop-dev#11 0x7f8a11045679 in exit stdlib/exit.c:139:3 htop-dev#12 0x7f8a1102dd10 in __libc_start_main csu/../csu/libc-start.c:342:3 htop-dev#13 0x428a19 in _start (/home/christian/Coding/workspaces/htop/htop+0x428a19) 0x60d000000080 is located 64 bytes inside of 144-byte region [0x60d000000040,0x60d0000000d0) freed by thread T0 here: #0 0x4a4f72 in free (/home/christian/Coding/workspaces/htop/htop+0x4a4f72) #1 0x566693 in Settings_delete /home/christian/Coding/workspaces/htop/Settings.c:32:4 #2 0x4ede10 in CommandLine_run /home/christian/Coding/workspaces/htop/CommandLine.c:393:4 htop-dev#3 0x4d6f32 in main /home/christian/Coding/workspaces/htop/htop.c:15:11 htop-dev#4 0x7f8a1102dd09 in __libc_start_main csu/../csu/libc-start.c:308:16 previously allocated by thread T0 here: #0 0x4a5372 in __interceptor_calloc (/home/christian/Coding/workspaces/htop/htop+0x4a5372) #1 0x57f61a in xCalloc /home/christian/Coding/workspaces/htop/XUtils.c:55:17 #2 0x5688a6 in Settings_new /home/christian/Coding/workspaces/htop/Settings.c:392:21 htop-dev#3 0x4ecb57 in CommandLine_run /home/christian/Coding/workspaces/htop/CommandLine.c:303:25 htop-dev#4 0x4d6f32 in main /home/christian/Coding/workspaces/htop/htop.c:15:11 htop-dev#5 0x7f8a1102dd09 in __libc_start_main csu/../csu/libc-start.c:308:16 SUMMARY: AddressSanitizer: heap-use-after-free /home/christian/Coding/workspaces/htop/Settings.c:329:26 in Settings_write

The signal handler will access the Settings struct, which gets freed at normal program finalization. When using leak sanitizers with ASAN_OPTIONS=abort_on_error=1, which runs after program termination, any leak causes SIGABRT to be raised, calling the crash handler, which will derefernce the freed Settings. ==44741==ERROR: AddressSanitizer: heap-use-after-free on address 0x60d000000080 at pc 0x0000005680df bp 0x7fffe335e960 sp 0x7fffe335e958 READ of size 8 at 0x60d000000080 thread T0 #0 0x5680de in Settings_write /home/christian/Coding/workspaces/htop/Settings.c:329:26 #1 0x4f77b7 in CRT_handleSIGSEGV /home/christian/Coding/workspaces/htop/CRT.c:1020:4 #2 0x7f8a1120c13f (/lib/x86_64-linux-gnu/libpthread.so.0+0x1413f) #3 0x7f8a11042ce0 in __libc_signal_restore_set signal/../sysdeps/unix/sysv/linux/internal-signals.h:86:3 #4 0x7f8a11042ce0 in raise signal/../sysdeps/unix/sysv/linux/raise.c:48:3 #5 0x7f8a1102c536 in abort stdlib/abort.c:79:7 #6 0x4c3db6 in __sanitizer::Abort() (/home/christian/Coding/workspaces/htop/htop+0x4c3db6) #7 0x4c2090 in __sanitizer::Die() (/home/christian/Coding/workspaces/htop/htop+0x4c2090) #8 0x4d0a17 in __lsan::HandleLeaks() (/home/christian/Coding/workspaces/htop/htop+0x4d0a17) #9 0x4cd950 in __lsan::DoLeakCheck() (/home/christian/Coding/workspaces/htop/htop+0x4cd950) #10 0x7f8a110454d6 in __run_exit_handlers stdlib/exit.c:108:8 #11 0x7f8a11045679 in exit stdlib/exit.c:139:3 #12 0x7f8a1102dd10 in __libc_start_main csu/../csu/libc-start.c:342:3 #13 0x428a19 in _start (/home/christian/Coding/workspaces/htop/htop+0x428a19) 0x60d000000080 is located 64 bytes inside of 144-byte region [0x60d000000040,0x60d0000000d0) freed by thread T0 here: #0 0x4a4f72 in free (/home/christian/Coding/workspaces/htop/htop+0x4a4f72) #1 0x566693 in Settings_delete /home/christian/Coding/workspaces/htop/Settings.c:32:4 #2 0x4ede10 in CommandLine_run /home/christian/Coding/workspaces/htop/CommandLine.c:393:4 #3 0x4d6f32 in main /home/christian/Coding/workspaces/htop/htop.c:15:11 #4 0x7f8a1102dd09 in __libc_start_main csu/../csu/libc-start.c:308:16 previously allocated by thread T0 here: #0 0x4a5372 in __interceptor_calloc (/home/christian/Coding/workspaces/htop/htop+0x4a5372) #1 0x57f61a in xCalloc /home/christian/Coding/workspaces/htop/XUtils.c:55:17 #2 0x5688a6 in Settings_new /home/christian/Coding/workspaces/htop/Settings.c:392:21 #3 0x4ecb57 in CommandLine_run /home/christian/Coding/workspaces/htop/CommandLine.c:303:25 #4 0x4d6f32 in main /home/christian/Coding/workspaces/htop/htop.c:15:11 #5 0x7f8a1102dd09 in __libc_start_main csu/../csu/libc-start.c:308:16 SUMMARY: AddressSanitizer: heap-use-after-free /home/christian/Coding/workspaces/htop/Settings.c:329:26 in Settings_write

ProcessList.c:242:36: runtime error: left shift of 1 by 31 places cannot be represented in type 'int' #0 0x561cfec000a8 in ProcessList_buildTreeBranch ProcessList.c:242:36 #1 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 #2 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 htop-dev#3 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 htop-dev#4 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 htop-dev#5 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 htop-dev#6 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 htop-dev#7 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 htop-dev#8 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 htop-dev#9 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 htop-dev#10 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 htop-dev#11 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 htop-dev#12 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 htop-dev#13 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 htop-dev#14 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 htop-dev#15 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 htop-dev#16 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 htop-dev#17 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 htop-dev#18 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 htop-dev#19 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 htop-dev#20 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 htop-dev#21 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 htop-dev#22 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 htop-dev#23 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 htop-dev#24 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 htop-dev#25 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 htop-dev#26 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 htop-dev#27 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 htop-dev#28 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 htop-dev#29 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 htop-dev#30 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 htop-dev#31 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 htop-dev#32 0x561cfebfb734 in ProcessList_buildTree ProcessList.c:312:10 htop-dev#33 0x561cfebfb050 in ProcessList_updateDisplayList ProcessList.c:326:10 htop-dev#34 0x561cfebfc58b in ProcessList_rebuildPanel ProcessList.c:374:4 htop-dev#35 0x561cfec07953 in checkRecalculation ScreenManager.c:139:7 htop-dev#36 0x561cfec07953 in ScreenManager_run ScreenManager.c:226:10 htop-dev#37 0x561cfeb8899a in CommandLine_run CommandLine.c:378:4 htop-dev#38 0x561cfeb6d6d4 in main htop.c:15:11 htop-dev#39 0x7f14860291e9 in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16 htop-dev#40 0x7f148602929b in __libc_start_main csu/../csu/libc-start.c:392:3 htop-dev#41 0x561cfeaafb20 in _start (htop+0x105b20) (BuildId: fc4b9e52ffc111ca8b4cd53136a238414120a858)

Also increase the limit for nesting by using 64 bit integers. ProcessList.c:242:36: runtime error: left shift of 1 by 31 places cannot be represented in type 'int' #0 0x561cfec000a8 in ProcessList_buildTreeBranch ProcessList.c:242:36 #1 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 #2 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 htop-dev#3 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 htop-dev#4 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 htop-dev#5 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 htop-dev#6 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 htop-dev#7 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 htop-dev#8 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 htop-dev#9 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 htop-dev#10 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 htop-dev#11 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 htop-dev#12 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 htop-dev#13 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 htop-dev#14 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 htop-dev#15 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 htop-dev#16 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 htop-dev#17 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 htop-dev#18 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 htop-dev#19 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 htop-dev#20 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 htop-dev#21 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 htop-dev#22 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 htop-dev#23 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 htop-dev#24 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 htop-dev#25 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 htop-dev#26 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 htop-dev#27 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 htop-dev#28 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 htop-dev#29 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 htop-dev#30 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 htop-dev#31 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 htop-dev#32 0x561cfebfb734 in ProcessList_buildTree ProcessList.c:312:10 htop-dev#33 0x561cfebfb050 in ProcessList_updateDisplayList ProcessList.c:326:10 htop-dev#34 0x561cfebfc58b in ProcessList_rebuildPanel ProcessList.c:374:4 htop-dev#35 0x561cfec07953 in checkRecalculation ScreenManager.c:139:7 htop-dev#36 0x561cfec07953 in ScreenManager_run ScreenManager.c:226:10 htop-dev#37 0x561cfeb8899a in CommandLine_run CommandLine.c:378:4 htop-dev#38 0x561cfeb6d6d4 in main htop.c:15:11 htop-dev#39 0x7f14860291e9 in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16 htop-dev#40 0x7f148602929b in __libc_start_main csu/../csu/libc-start.c:392:3 htop-dev#41 0x561cfeaafb20 in _start (htop+0x105b20) (BuildId: fc4b9e52ffc111ca8b4cd53136a238414120a858)

Also increase the limit for nesting by using 64 bit integers. ProcessList.c:242:36: runtime error: left shift of 1 by 31 places cannot be represented in type 'int' #0 0x561cfec000a8 in ProcessList_buildTreeBranch ProcessList.c:242:36 #1 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 #2 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 #3 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 #4 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 #5 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 #6 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 #7 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 #8 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 #9 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 #10 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 #11 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 #12 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 #13 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 #14 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 #15 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 #16 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 #17 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 #18 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 #19 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 #20 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 #21 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 #22 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 #23 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 #24 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 #25 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 #26 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 #27 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 #28 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 #29 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 #30 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 #31 0x561cfebffec2 in ProcessList_buildTreeBranch ProcessList.c:243:7 #32 0x561cfebfb734 in ProcessList_buildTree ProcessList.c:312:10 #33 0x561cfebfb050 in ProcessList_updateDisplayList ProcessList.c:326:10 #34 0x561cfebfc58b in ProcessList_rebuildPanel ProcessList.c:374:4 #35 0x561cfec07953 in checkRecalculation ScreenManager.c:139:7 #36 0x561cfec07953 in ScreenManager_run ScreenManager.c:226:10 #37 0x561cfeb8899a in CommandLine_run CommandLine.c:378:4 #38 0x561cfeb6d6d4 in main htop.c:15:11 #39 0x7f14860291e9 in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16 #40 0x7f148602929b in __libc_start_main csu/../csu/libc-start.c:392:3 #41 0x561cfeaafb20 in _start (htop+0x105b20) (BuildId: fc4b9e52ffc111ca8b4cd53136a238414120a858)

fix width of AffinitPanel

94b8c2e

The panel size of 15 includes the gap to the next panel, thus use 14 as the minimum size and let the caller of `AffinityPanel_new` handle the gap.

natoscott merged commit 4a8ae4b into htop-dev:master Aug 26, 2020

bertwesarg deleted the affinity-fix-panel-width branch September 2, 2020 07:33

fasterit mentioned this pull request Jan 9, 2021

htop, run strace (key s) -> assert fails / segfaults #459

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix width of `AffinitPanel` #13

fix width of `AffinitPanel` #13

fix width of AffinitPanel #13

fix width of AffinitPanel #13

Conversation

fix width of `AffinitPanel` #13

fix width of `AffinitPanel` #13