perf: Optimize format_word function performance by using direct unicode mapping #245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // checked char is in range of fullwidth number and alphabetic | ||
| unsafe { char::from_u32_unchecked(c as u32 - 0xFEE0) } | ||
| } | ||
| '\u{3000}' => ' ', |
There was a problem hiding this comment.
你怎么知道我之前那个看不见的空格是 \u{3000} 的? 😂
There was a problem hiding this comment.
https://en.wikipedia.org/wiki/Halfwidth_and_Fullwidth_Forms_(Unicode_block)
U+FF00 does not correspond to a fullwidth ASCII 20 (space character), since that role is already fulfilled by U+3000 "ideographic space".
huacnlee
reviewed
Mar 23, 2025
| let out = text | ||
| .chars() | ||
| .map(|c| match c { | ||
| '\u{FF10}'..='\u{FF19}' | '\u{FF21}'..='\u{FF3A}' | '\u{FF41}'..='\u{FF5A}' => { |
There was a problem hiding this comment.
There was a problem hiding this comment.
看起来这里可以改成完整的 Fullwidth 表格，之前还有一些我漏掉的，比如：＠ -> @
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR optimizes the
format_wordfn to improve performance when converting full-width characters to half-width.Changes
This change should result in lower CPU usage and memory allocation when processing text with many full-width characters. for example, run the
format_json_2kbenchmark on my local pc: