8000 added closure argument to optimizer.step() by pmelchior · Pull Request #105 · huggingface/accelerate · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

added closure argument to optimizer.step() #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 15, 2021
Merged

added closure argument to optimizer.step() #105

merged 3 commits into from
Jun 15, 2021

Conversation

pmelchior
Copy link
Contributor

Optimizers generally support a closure argument. This PR adds the argument to AcceleratedOptimizer and passes it on. Tested on CPU and GPU, but not on TPU.

sgugger
sgugger approved these changes Jun 15, 2021
View reviewed changes
Copy link
Collaborator
@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

@pmelchior @sgugger
XLA argument as kwarg
721371e 
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
sgugger
sgugger reviewed Jun 15, 2021
View reviewed changes
@pmelchior @sgugger
check for closure in XLA args
ce7d2c1 
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
@sgugger sgugger merged commit 45c185d into huggingface:main Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgugger sgugger sgugger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pmelchior @sgugger
0