Update example scripts #307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
sgugger
reviewed
Apr 4, 2022
There was a problem hiding this comment.
Left some comments! I was thinking the base example should be left as is to be as simple as possible, and we could add a "complete_nlp_example" that contains the checkpoint and sharding, so that a reader only wanting a base training loop is not too lost. Wdyt?
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
sgugger
reviewed
Apr 4, 2022
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
sgugger
approved these changes
Apr 4, 2022
| @@ -149,10 +149,6 @@ def training_function(config, args): | |||
| model, optimizer, train_dataloader, eval_dataloader, lr_scheduler | |||
| ) | |||
|
|
|||
| # Instantiate learning rate scheduler after preparing the training dataloader as the prepare method | |||
| # may change its length. | |||
| lr_scheduler = OneCycleLR(optimizer=optimizer, max_lr=lr, epochs=num_epochs, steps_per_epoch=len(train_dataloader)) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start of updating the example scripts to use both the save/load_state and tracking