8000 Support more functionalities for MUSA backend by fmo-mt · Pull Request #3359 · huggingface/accelerate · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Support more functionalities for MUSA backend #3359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 23, 2025
Merged

Support more functionalities for MUSA backend #3359

merged 2 commits into from
Jan 23, 2025

Conversation

fmo-mt
Copy link
Contributor
@fmo-mt fmo-mt commented Jan 21, 2025 •
edited
Loading

What does this PR do?

We have already supported MUSA backend since v0.33.0, and accelerate have supported more functionalities, like FSDP, of which MUSA backend doesn't included.

This PR just make MUSA backend adapted with all these features.

cc @SunMarc @muellerzr

SunMarc
SunMarc approved these changes Jan 22, 2025 8000
View reviewed changes
Copy link
Member
@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@SunMarc SunMarc requested a review from muellerzr January 22, 2025 14:49
@fmo-mt
Copy link
Contributor Author
fmo-mt commented Jan 22, 2025

@SunMarc Forgot to run make style && make quality, and I fixed some lint error, seems the CI workflow needs another approval lol

@SunMarc SunMarc merged commit 8f2d31c into huggingface:main Jan 23, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SunMarc SunMarc SunMarc approved these changes

@muellerzr muellerzr Awaiting requested review from muellerzr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fmo-mt @SunMarc
0