8000 fix: ensure CLI args take precedence over config file. by cyr0930 · Pull Request #3409 · huggingface/accelerate · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: ensure CLI args take precedence over config file. #3409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 28, 2025
Merged

fix: ensure CLI args take precedence over config file. #3409

merged 3 commits into from
Feb 28, 2025

Conversation

cyr0930
Copy link
Contributor
@cyr0930 cyr0930 commented Feb 24, 2025 •
edited
Loading

What does this PR do?

Reapply this PR (#2757) with some fixes.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@muellerzr @lain-s

@BenjaminBossan
Copy link
Member

Thanks for the PR. Could you please provide an example where currently the CLI args don't take precedence and that would be resolved by your fix?

@cyr0930
Copy link
Contributor Author
cyr0930 commented Feb 25, 2025 •
edited
Loading

I added a test case.
As you can see in the test case, if config file options are instance of dict, they preceded cli options.
"deepspeed_config_file" option in the test is one of the case.

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@cyr0930
Copy link
Contributor Author
cyr0930 commented Feb 26, 2025

I think there's nothing to change in the document. Mention this in the release note would be fine.

muellerzr
muellerzr approved these changes Feb 28, 2025
View reviewed changes
Copy link
Contributor
@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this with deepspeed!

@muellerzr muellerzr merged commit c7b3625 into huggingface:main Feb 28, 2025
25 checks passed
@cyr0930 cyr0930 deleted the bug/dict_args branch March 1, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muellerzr muellerzr muellerzr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cyr0930 @BenjaminBossan @HuggingFaceDocBuilderDev @muellerzr
0