Remove deprecated PyTorch/XLA APIs #3484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @SunMarc see if anyone can take a review. Thanks |
SunMarc
approved these changes
Apr 7, 2025
| @@ -22,6 +22,7 @@ | |||
|
|
|||
| if is_torch_xla_available(): | |||
| import torch_xla.core.xla_model as xm | |||
| import torch_xla.runtime as xr | |||
There was a problem hiding this comment.
do we require a specific version of torch_xla to use xr.world_size()
8000
or xr.global_ordinal() ?
|
Could you also do the same to transformers library as we had an issue that the deprecation ? |
4 tasks
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
Hi @zpcore @SunMarc can you also update https://github.com/huggingface/accelerate/blob/main/src/accelerate/state.py#L284 (for TPU only)? |
4 tasks
|
What needs to be changed @jeffhataws ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
PyTorch/XLA has deprecated bunch of APIs (pytorch/xla#8915) for the upcoming 2.7 release. This PR integrates the change into accelerate package.