8000 [FSDP2] Enable FULL_STATE_DICT by S1ro1 · Pull Request #3527 · huggingface/accelerate · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[FSDP2] Enable FULL_STATE_DICT #3527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 23, 2025
Merged

[FSDP2] Enable FULL_STATE_DICT #3527

merged 6 commits into from
Apr 23, 2025

Conversation

S1ro1
Copy link
Member
@S1ro1 S1ro1 commented Apr 22, 2025

This PR enables FULL_STATE_DICT to be used with FSDP2 in Accelerate, this unblocks also saving via Trainer.save_state and in conjuction with PR huggingface/transformers#37689 making FSDP2 fully compatible with checkpointing methods in transformers (save_pretrained/save_state)

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member
@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this ! LGTM, just a new questions for me

@SunMarc
Copy link
Member
SunMarc commented Apr 23, 2025

Just ran the slow CI for this PR https://github.com/huggingface/accelerate/actions/runs/14621160409

@S1ro1 S1ro1 force-pushed the fsdp2-full-state-dict branch from 162b8b2 to 0a9d302 Compare April 23, 2025 15:30
@S1ro1 S1ro1 force-pushed the fsdp2-full-state-dict branch from 0a9d302 to 997cd31 Compare April 23, 2025 15:54
@S1ro1 S1ro1 merged commit 8fb0735 into main Apr 23, 2025
28 of 29 checks passed
@S1ro1 S1ro1 deleted the fsdp2-full-state-dict branch April 23, 2025 16:03
Copy link
Member
@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0