8000 Fix the issue where `set_epoch` does not take effect. by hongjx175 · Pull Request #3556 · huggingface/accelerate · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix the issue where set_epoch does not take effect. #3556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 12, 2025
Merged

Fix the issue where set_epoch does not take effect. #3556

merged 2 commits into from
May 12, 2025

Conversation

hongjx175
Copy link
Contributor
@hongjx175 hongjx175 commented May 11, 2025 •
edited
Loading

What does this PR do?

Fixes # (issue)
When training for multiple epochs, the set_epoch defined in the Sampler does not work because set_epoch in DataLoaderShard is missing a further level call.

image

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@SunMarc @zach-huggingface

SunMarc
SunMarc approved these changes May 12, 2025
View reviewed changes
Copy link
Member
@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ! Make sense

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@SunMarc
Copy link
Member
SunMarc commented May 12, 2025

@bot /style

@github-actions GitHub Actions
Copy link
Contributor

Style fixes have been applied. View the workflow run here.

@SunMarc SunMarc merged commit ddc49f1 into huggingface:main May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SunMarc SunMarc SunMarc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hongjx175 @HuggingFaceDocBuilderDev @SunMarc
0