8000 Fix OneCycle step length when in multiprocess by muellerzr · Pull Request #385 · huggingface/accelerate · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix OneCycle step length when in multiprocess #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 23, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/accelerate/scheduler.py
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,9 @@ def step(self, *args, **kwargs):
# num_processes steps per training step
num_processes = AcceleratorState().num_processes
for _ in range(num_processes):
self.scheduler.step(*args, **kwargs)
# Special case when using OneCycle and `drop_last` was not used
if getattr(self.scheduler, "total_steps", 0) <= self.scheduler.last_epoch:
self.scheduler.step(*args, **kwargs)

# Passthroughs
def get_last_lr(self):
Expand Down
0