8000 Add tags to spaces by lvwerra · Pull Request #162 · huggingface/evaluate · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add tags to spaces #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 5, 2022
Merged

Add tags to spaces #162

merged 3 commits into from
Jul 5, 2022

Conversation

lvwerra
Copy link
Member
@lvwerra lvwerra commented Jun 27, 2022

This extends the script that uploads the repository's modules to spaces to also propagate the evaluate repository tags. That way we can load modules from spaces with the same revision as we currently can from the repository. Note that this has no effect until we change the loading mechanism to load the canonical modules from spaces.

@lvwerra lvwerra requested review from osanseviero and lhoestq June 27, 2022 13:22
@HuggingFaceDocBuilderDev
Copy link
HuggingFaceDocBuilderDev commented Jun 27, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

osanseviero
osanseviero approved these changes Jun 28, 2022
View reviewed changes
Copy link
Contributor
@osanseviero osanseviero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good 😄 🚀

lhoestq
lhoestq reviewed Jun 28, 2022
View reviewed changes
Copy link
Member
@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the version of evaluate is enough instead of pushing the full hash ?

That's what we do in datasets right now

@lvwerra
Copy link
Member Author
lvwerra commented Jun 28, 2022 •
edited
Loading

Maybe the version of evaluate is enough instead of pushing the full hash ?

That's what we do in datasets right now

The script just adds the part of the evaluate commit hash to the commit message on the space, so one can backtrace when a change on a space was added in evaluate. You think that's too verbose?

See e.g. https://huggingface.co/spaces/evaluate-metric/sacrebleu/commits/main

If the commit on main has a tag then it is just propagated and the same tag is added to the space.

@lvwerra lvwerra requested a review from lhoestq June 29, 2022 15:19
lhoestq
lhoestq approved these changes Jul 5, 2022
View reviewed changes
Copy link
Member
@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok cool ! thanks :)

@lvwerra lvwerra merged commit 9f241f5 into main Jul 5, 2022
@lvwerra lvwerra deleted the add-tags-to-spaces branch July 5, 2022 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osanseviero osanseviero osanseviero approved these changes

@lhoestq lhoestq lhoestq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lvwerra @HuggingFaceDocBuilderDev @osanseviero @lhoestq
0