added MASE, sMAPE and MAPE metrics #330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
|
Hi @kashif, thanks for adding this - the implementation looks great! There seems to be an issue with the example in the docstring, maybe rounding the results would help. Also, could you add a Let me know if you need any help! |
|
thanks @lvwerra let me fix it! |
|
@lvwerra would be happy for another review |
|
the tests seems to be failing due to something else I believe |
shchur
reviewed
Nov 2, 2022
|
Thank you! |
NimaBoscarino
pushed a commit
to NimaBoscarino/evaluate
that referenced
this pull request
Nov 9, 2022
* added mean_absolute_percentage_error * fix output * more decimal places * added readme and requirements.txt * added formula * fix outputs * grammer * formatting * fix tests * added smape * formatting * fix tests * whitespace * fix formula * added mase * make style * typo * added reference_urls * latest edition * fix doc * better Description * Fix mape range * cite sklearn api and helpers * Update README.md * Update README.md * Update README.md * Update README.md * fix markdown * new line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 3 time series specific metrics...