-
Notifications
You must be signed in to change notification settings - Fork 277
add r^2 metric #407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add r^2 metric #407
Conversation
The documentation is not available anymore as the PR was closed or merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good, I think there is an issue with YAML formatting I pointed out.
Also looking at the CI it seems that your example returns |
Co-authored-by: Leandro von Werra <lvwerra@users.noreply.github.com>
I must have overlooked 👀 I have updated the expected metric result for example. |
This time there should be no error, would you check? @lvwerra |
I think you might need another |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now!
* add r^2 metric * Update metrics/r_squared/README.md Co-authored-by: Leandro von Werra <lvwerra@users.noreply.github.com> * Update metrics/r_squared/README.md * Update metrics/r_squared/Readme * Added r_squared metric * Update metrics/r_squared/README.md * Update r_squared metric * Update metrics/r_squared/README.md * Update metrics/r_squared/app.py * Update metrics/r_squared/r_squared.py * Update metrics/r_squared/requirements.txt * fix: imports and format code according to Black standard * Fix: R-squared evaluation metric to round off value to 3 decimal places --------- Co-authored-by: Leandro von Werra <lvwerra@users.noreply.github.com>
I turned off the old pr and rebuilt the pr to add the r_squared metric :) I tested it locally and it seems ok... @lvwerra