8000 Ignore documents with "output" scheme by HennerM · Pull Request #59 · huggingface/llm-ls · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Ignore documents with "output" scheme #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2024
Merged

Ignore documents with "output" scheme #59

merged 1 commit into from
Jan 28, 2024

Conversation

HennerM
Copy link
Contributor
@HennerM HennerM commented Jan 20, 2024

In the VSCode extension there is a "*" documentFilter set (https://github.com/huggingface/llm-vscode/blob/master/src/extension.ts#L63), which sends document did_change events for ALL updates it has e.g. when files on the filesystem changed (which will have scheme file: or unsaved ones untitled. However this also includes the VSCode "Output" tab.

As it happens this output is coming from llm-ls itself. Whenever we log a message to the client, e.g. in

self.client
    .log_message(MessageType::INFO, format!("{uri} changed"))
    .await;

the output changes and we trigger the event. This is problematic in the case of the mentioned log, since this basically triggers an infinite loop of logs and changed events.

There are two ways to fix this:

  1. setting the documentFilter in the VSCode client to ignore output scheme, I think this could look like the following:
documentSelector: [{ scheme: 'file'}, {scheme: 'untitled'}],

The problem is there is no "negate" operator, which means we have to exhaustively list everything we want to get, and I couldn't find an enumeration.
2. just ignoring the output scheme. This seems like low risk, since no valuable input for code completion can get out of it anyway

Fixes huggingface/llm-vscode#120

@HennerM HennerM mentioned this pull request Jan 20, 2024
Closed
@HennerM HennerM force-pushed the ignore-output-changes branch from 4ede048 to af1e3f4 Compare January 20, 2024 17:13
@HennerM HennerM force-pushed the ignore-output-changes branch from af1e3f4 to 5d2742a Compare January 23, 2024 22:53
@McPatate McPatate merged commit c2fbac2 into huggingface:main Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McPatate McPatate McPatate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Continuous file change events
2 participants
@HennerM @McPatate
0