8000 Fix OpenAIServerModel client by durd07 · Pull Request #975 · huggingface/smolagents · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix OpenAIServerModel client #975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 14, 2025
Merged

Fix OpenAIServerModel client #975

merged 4 commits into from
Mar 14, 2025

Conversation

durd07
Copy link
Contributor
@durd07 durd07 commented Mar 14, 2025

The official code doesn't work, self.client will be always set to None.

albertvillanova
albertvillanova approved these changes Mar 14, 2025
View reviewed changes
Copy link
Member
@albertvillanova albertvillanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good catch!

This confirms why tests are so important... 😅

Fixing also AzureOpenAIServerModel.

albertvillanova
albertvillanova reviewed Mar 14, 2025
View reviewed changes
Copy link
Member
@albertvillanova albertvillanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added tests as well.

@albertvillanova albertvillanova merged commit 13afa93 into huggingface:main Mar 14, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albertvillanova albertvillanova albertvillanova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@durd07 @albertvillanova
0